Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Song Liu <songliubraving@fb.com>
To:     Wan Jiabing <wanjiabing@vivo.com>
CC:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] bpf: use vmemdup_user instead of kvmalloc and
 copy_from_user
Thread-Topic: [PATCH 3/3] bpf: use vmemdup_user instead of kvmalloc and
 copy_from_user
Thread-Index: AQHYZgsMHuDdmoOKb0i6sfPd8TDQeK0bc0KA
Date:   Thu, 12 May 2022 16:45:24 +0000
Message-ID: <4C02E841-C402-4862-9C54-FBD5686E2FB4@fb.com>
References: <20220512141710.116135-1-wanjiabing@vivo.com>
 <20220512141710.116135-4-wanjiabing@vivo.com>
In-Reply-To: <20220512141710.116135-4-wanjiabing@vivo.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l3SnWezd8OFgsI0p0cT878I73MjGUPO14ulm7alx0QXY3GSVvPRb8eO30uOe?=
 =?us-ascii?Q?PJJ8cnJ+30/YMc4SGWE6JmANTWza0W/qjL4MCyXa5XZw/dAnXaa/Bz7olpT9?=
 =?us-ascii?Q?lB+esEi3F/Z0a3lRHEbo4Qy7H51suPECDZjIzVX44nxxI6YXz6ERbTD9ujWH?=
 =?us-ascii?Q?9fxceQZhZKqz8F4vuk5BmIKTCeUM8usqdMbs/KnTFoGmtirwAJ//aE4qhLHa?=
 =?us-ascii?Q?z25FA4JFiYFjqLwtlosAVC9rW1uyLLPQLoY17tXtwrRgbrwqcE/5YPpTZBST?=
 =?us-ascii?Q?/iC9AmhsdV/mR/3RESoq/wJ91u9Bjh5+hMSOd3f4lVjc/yL7mMg8qLh02XFh?=
 =?us-ascii?Q?fM99ZcIBn8FVLANivwX7PcY019Gvn5t6JE3OVjpQEkbcP8oDRW+xzFrzJ+AV?=
 =?us-ascii?Q?wOdYv+j0DDqdR6SDYlwWy4bpEtbtaIBSvQcx6JF6gkXiED2wF2NzAyJX4o4y?=
 =?us-ascii?Q?tzYXUuggfChHW4+H1RucsmfVD8vNRO+EGW0XEWX0W9dVF74kSlnODpA11UZ5?=
 =?us-ascii?Q?FnBaZXW9sxxtBrr8ItTCiJiEVOCxfbIzPTuSgCyz/2XKjEtbhXD2+O3o0Qxx?=
 =?us-ascii?Q?0RTFCcEQY4S424YsRXNUEYXb5dm8ZWRn7MBQR6a5pqf6o2dVXT+yJ6EI/9Z3?=
 =?us-ascii?Q?gobOErO7Rex5YqJHZZLf9mAg4/8wKQvqYNSDw/Y9eDCBbnvgn1HpXioSGCxb?=
 =?us-ascii?Q?3KaliPWb2QnPQAQ+joaoGjpMdsKoOeRtZ7LjHanF0tSQ+6C9sIFPgJNgh11M?=
 =?us-ascii?Q?tlh+VGC/EwaSMp46WheEJA6i4Om2Arep/CtoBuNC1CnirHKuRDluv7gQvykF?=
 =?us-ascii?Q?QAXAUBpaFFVXGIZAtZZZiRbQ/pxQPXUEAS9eFKqYfLd2t63qEp2ScLjLCMw/?=
 =?us-ascii?Q?1PxJNNd+bOVVPXxIZZPxoC+nXzMvpziopyOuWxjvAl+7QyPh9T+bQMdRz2pT?=
 =?us-ascii?Q?VnoMH6rDiOMvJYsKNfFGYzp8h15phvPWVtoQc9WARxub0xwYc0WcMT1CLINh?=
 =?us-ascii?Q?xp/I3vnwdKl/xeocqHaWpNsa7HJM3ag5c5JWSxC56cA03eWvTLW3YYAbUwqo?=
 =?us-ascii?Q?O9N/POuzDlGdvpN9dW6LOt8yZu9rkuhIRFWeMwAqm8IRnx3frZf5ijk52EEE?=
 =?us-ascii?Q?kJU0j/9fgXDn2Mn6aujxYnTtaRZ3ajJQoaTjo0jGZRBjOzsJUfC4zgniYMjz?=
 =?us-ascii?Q?uuEc/+QAL1Zi8tKPAcfBTHdy96I9CfuOp9tNoUCBZ65iuK00levXTUtptfmc?=
 =?us-ascii?Q?gp/ObwaPnJ2aAUow8jBSiym6Rp3KEPvtZDZm/V1BUixuElxxOEOmFhVHc6YK?=
 =?us-ascii?Q?rGRErQecmUZ3O55grVyZRTzYhE+QXE/Uh8A5tml6T8DTncy+4PhYs8fZ69JS?=
 =?us-ascii?Q?e2T6mJuwSNHFjXuMnVTYHOogyo0GYt0ZX/irng+7guMaUwt4p+y5Y3Rv6Xtu?=
 =?us-ascii?Q?3OxFLgiSJaJD6mPt6CielTlEWWerfKKuDjoyzIMWwA/1rPgDr/1hzIwPtuEH?=
 =?us-ascii?Q?RdQgcuwJk9zo/0vn0iQIAaAuWkX/rmsEiwNJGSyvr03Loa5qElpfLlGPg9+T?=
 =?us-ascii?Q?KEHoTVqag1P2iQNnPsLc58DHXDRxVW9R1XFKsYfTn/GyJCqu4zdPmhN1Em6C?=
 =?us-ascii?Q?poWwGxcncqRBTPiiIcxEJviR0U4GABai/AWfnDYVqM5aFiKsqc8ERYXbIW7U?=
 =?us-ascii?Q?1cfvGz2giq1bghUAMnjdPeOB5/zONhiwP66603Wj8de9M2HOfal7ZMNg2fJM?=
 =?us-ascii?Q?vwx7xyqTdEonVEc8AgNNfnzF41O3sUXXXoxhlcJ8cXC/bAtH5UE9?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A15D40C47A32B945A6A29E77D81ECE7E@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e045f05-797d-4435-c300-08da3436cfa7
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2022 16:45:24.2634
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SgJzfpgMAd9F60pbEFJpXzUC2ZbQqhisQTCAP0NlCDcyek++fk5od5bLWjj6iRmGCkC9VOpEgSkFayHLu2j4qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB4091
X-Proofpoint-ORIG-GUID: MP2qQOgDS9bZA6SO1g6FKxo9Lx_JrfLk
X-Proofpoint-GUID: MP2qQOgDS9bZA6SO1g6FKxo9Lx_JrfLk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-12_14,2022-05-12_01,2022-02-23_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 12, 2022, at 7:17 AM, Wan Jiabing <wanjiabing@vivo.com> wrote:
> 
> Fix following coccicheck warning:
> ./kernel/trace/bpf_trace.c:2488:12-20: WARNING opportunity for vmemdup_user
> 
> Use vmemdup_user instead of kvmalloc and copy_from_user.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> kernel/trace/bpf_trace.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
> index 1b0db8f78dc8..48fc97a6db50 100644
> --- a/kernel/trace/bpf_trace.c
> +++ b/kernel/trace/bpf_trace.c
> @@ -2483,15 +2483,11 @@ int bpf_kprobe_multi_link_attach(const union bpf_attr *attr, struct bpf_prog *pr
> 
> 	ucookies = u64_to_user_ptr(attr->link_create.kprobe_multi.cookies);
> 	if (ucookies) {
> -		cookies = kvmalloc(size, GFP_KERNEL);
> -		if (!cookies) {
> -			err = -ENOMEM;
> +		cookies = vmemdup_user(ucookies, size);

vmemdup_user() uses GFP_USER, so this is a behavior change. 

Song

> +		if (IS_ERR(cookies)) {
> +			err = PTR_ERR(cookies);
> 			goto error_addrs;
> 		}
> -		if (copy_from_user(cookies, ucookies, size)) {
> -			err = -EFAULT;
> -			goto error_cookies;
> -		}
> 	}
> 
> 	link = kzalloc(sizeof(*link), GFP_KERNEL);
> -- 
> 2.35.1
>