Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 13 May 2022 00:45:05 +0000
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Gou Hao <gouhao@uniontech.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        jiaofenfang@uniontech.com, willy@infradead.org
Subject: Re: [PATCH V2] fs: remove fget_many and fput_many interface
Message-ID: <Yn2qEej5rjnVKw5i@zeniv-ca.linux.org.uk>
References: <20211102024648.14578-1-gouhao@uniontech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211102024648.14578-1-gouhao@uniontech.com>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Tue, Nov 02, 2021 at 10:46:48AM +0800, Gou Hao wrote:
> These two interface were added in 091141a42 commit,
> but now there is no place to call them.
> 
> The only user of fput/fget_many() was removed in commit
> 62906e89e63b ("io_uring: remove file batch-get optimisation").
> 
> A user of get_file_rcu_many() were removed in commit 
> f073531070d2 ("init: add an init_dup helper").
> 
> And replace atomic_long_sub/add to atomic_long_dec/inc
> can improve performance.
> 
> Here are the test results of unixbench:
> 
> Cmd: ./Run -c 64 context1
> 
> Without patch:
> System Benchmarks Partial Index              BASELINE       RESULT    INDEX
> Pipe-based Context Switching                   4000.0    2798407.0   6996.0
>                                                                    ========
> System Benchmarks Index Score (Partial Only)                         6996.0
> 
> With patch:
> System Benchmarks Partial Index              BASELINE       RESULT    INDEX
> Pipe-based Context Switching                   4000.0    3486268.8   8715.7
>                                                                    ========
> System Benchmarks Index Score (Partial Only)                         8715.7
> 
> Signed-off-by: Gou Hao <gouhao@uniontech.com>

Rebased and applied, with deep apologies for having it fall through cracks
back in November.