Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1018216iob; Fri, 13 May 2022 19:49:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy47q2MIqyWVY6sniOcrCsHeKoL/LlS0gxlugYyS/Tlip2vd1P0IQRpgG/nFMg0br1hbRbs X-Received: by 2002:a7b:c350:0:b0:38c:6d3c:6c8 with SMTP id l16-20020a7bc350000000b0038c6d3c06c8mr6952936wmj.45.1652496569652; Fri, 13 May 2022 19:49:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652496569; cv=none; d=google.com; s=arc-20160816; b=Lms9A1x/mfbPa9UezujfAuIzYLvPEhOkL7AcD9OaCGtt+5fRlWpVo1eW9BE3QEH5UO c0hJ9lvAQHBa9/YiErvg2hsjSKKjxC/YueePh/62YeZZJ9mhQ2GGJg2AUQHeQexFH1I+ RaxKsHU6ypyQSVazsejj302eM0aSBGFDF0S3cWkWgCfI2HXzzsTa6D9DdzHQZ8sNVMke O8bsaucX/j9C/e8NKBSC9MO8CAbtuClUIsd8FX73+Q9l0koeoheuwu1ceXw8tbFkoJsS 3z3/lQqDJaZXyQP/aoUnK1RXHqg2O3oAJnRDVl0ao5v/tjwMXMoUn0rg8vXXw7I8bnBm 7EJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=N8e+gXdF4Rt32wAzlMm0HLoNXNQ/0Ieuz5/O4oeRXo4=; b=OBsMFyjpN32vHrPIWgxRHbFXxyDYMHIRUnjbSBlC9XtEm2vrnLV99LPk1e2xmudQKL +p0tcwwR5pwMy8R5QpEV+RobVnEG2Rb+nFo5Nr1rnO2Lj6SC93Zq8oa090Bahntwy3Ok nzR92OJgfcFF4LpUYqaYChvk2ZR95/vqmrefdwva081+sZFGIAu2PtWAuVxxbFlJRJvj E5BBcwSfEqFdpi2QZZEYAh93jlQ1jnCiXGGM9Iwe+1Ng328o5fzw3sfOS8QzRavthbz2 CwLMbts1GFdJiCK5673tXhxMWvhzkBZBtzGTC/u+JuJRuUu5Q5Dbu8STU+6C6bhxF7b0 vIRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hNhif9kR; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id a4-20020a056000100400b00207a2958852si3269577wrx.406.2022.05.13.19.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 19:49:29 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hNhif9kR; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9E55136EB99; Fri, 13 May 2022 16:36:09 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354481AbiELNiD (ORCPT + 99 others); Thu, 12 May 2022 09:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354353AbiELNiB (ORCPT ); Thu, 12 May 2022 09:38:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4301E14C752 for ; Thu, 12 May 2022 06:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652362680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N8e+gXdF4Rt32wAzlMm0HLoNXNQ/0Ieuz5/O4oeRXo4=; b=hNhif9kRbq52zu86Cbt+AzojTQuexxUTnvhzgVS4eRH9thd0sCrUkjN2e3+KF5twCgOS4G /i/Sae7Vfi7w7YRK4Ku739twdqQvEIlW2ubtaI0WSH/P4zOmJ+5ak1qMk5dO+WWNk7x5xz xQ3NgXejmn8B4yzYDUpYUUz7kOc6aRQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-207-r7d66dYdNLCBVYD_3NEFdQ-1; Thu, 12 May 2022 09:37:59 -0400 X-MC-Unique: r7d66dYdNLCBVYD_3NEFdQ-1 Received: by mail-wm1-f71.google.com with SMTP id i131-20020a1c3b89000000b00393fbb0718bso4429507wma.0 for ; Thu, 12 May 2022 06:37:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=N8e+gXdF4Rt32wAzlMm0HLoNXNQ/0Ieuz5/O4oeRXo4=; b=i/4iS1KlFIxekLijppELRheZ0foQmYPmYCSM73hm1mhuMkuE+4RqkSqL2o6EyETBBO N6K5Ur+yzOjA9Zb0e23Ycr8xden9rsru3uzAaD0Tdy6+6h2Ebin9WaX1N0pAk+61X8Dg dhnjNbC/livh5vU/pnDd/DLn14fUcA1/chHX0wpI/mcncBS/SFg6g27lQK6C9KttMIFE 8hxXwBjCrhIK9BbgYr0HJUAzt7VlWcoKeD8CNBkkAGChPDjZm5ngAH09EI16CIaJ2eB5 M22jiE8N06Noxwi6AO9yEK4046E2SZQfOPe9r/jc22n9wpTm1mFTj9nvTt6yxt8yf9T7 DSGg== X-Gm-Message-State: AOAM53321kHxybd5rZtP4OPiUGD3Fmifjp6hiuPGXotYQTsrCy5lfG6A o5fPnWj+vIj7qTFtIj59v4msZZ3nyrb7XrEMowj0KB3IMTVdyD2099l7+QRmJJ7MpRrQQnw7u8y 1mkGcGVa/ULgeeH95zKasxn8A X-Received: by 2002:a5d:61c2:0:b0:20a:d92f:9056 with SMTP id q2-20020a5d61c2000000b0020ad92f9056mr26892242wrv.652.1652362677943; Thu, 12 May 2022 06:37:57 -0700 (PDT) X-Received: by 2002:a5d:61c2:0:b0:20a:d92f:9056 with SMTP id q2-20020a5d61c2000000b0020ad92f9056mr26892230wrv.652.1652362677713; Thu, 12 May 2022 06:37:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:d200:ee5d:1275:f171:136d? (p200300cbc701d200ee5d1275f171136d.dip0.t-ipconnect.de. [2003:cb:c701:d200:ee5d:1275:f171:136d]) by smtp.gmail.com with ESMTPSA id y25-20020a1c4b19000000b0039489e1bbd6sm2553468wma.47.2022.05.12.06.37.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 06:37:56 -0700 (PDT) Message-ID: Date: Thu, 12 May 2022 15:37:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 07/15] mm/swap: remove unneeded p != NULL check in __swap_duplicate Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org Cc: willy@infradead.org, vbabka@suse.cz, dhowells@redhat.com, neilb@suse.de, apopple@nvidia.com, surenb@google.com, peterx@redhat.com, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220509131416.17553-1-linmiaohe@huawei.com> <20220509131416.17553-8-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220509131416.17553-8-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.05.22 15:14, Miaohe Lin wrote: > If p is NULL, __swap_duplicate will already return -EINVAL. So if we > reach here, p must be non-NULL. > > Signed-off-by: Miaohe Lin Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb