Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <23cf0d6b-3577-b9c1-e20d-e54b6823f309@suse.com>
Date:   Thu, 12 May 2022 11:58:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] drivers:Modify the return value to void
Content-Language: en-US
To:     Zhou jie <zhoujie@nfschina.com>, Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220512093210.GA6602@localhost.localdomain>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220512093210.GA6602@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SJyfhD/d9Nqmt6mFl+L1R+ut3gwyFahxa1ezNbpOup9MKNGHP+TKhECdXQR9?=
 =?us-ascii?Q?MZIDKYIvTK0Wjt/dDFWJYwCfzLNay5mY1HhkWS+YJ9ZaZY/WR1z+Y5UYj5G0?=
 =?us-ascii?Q?vdEf7vxsJS4CF0ty4uF4AJJNZDtStrymKN7dkbWsoPYa+6JSP8iD1n2UEhuR?=
 =?us-ascii?Q?kMCMPah1wDfjcNMQeACEBKj59MgEd2ShFLbLnXONQbGQM7C745fyl5yJNd3m?=
 =?us-ascii?Q?mWkOsmz5cBj9zaLPBm3wifYuyLtu9vt4OeA+A9ER6EO+snaQW+whClGcfx8i?=
 =?us-ascii?Q?9mgk+zKKkA7QdP//GI112dgvkxIT+hVkkDgsqjX4O0vlkYhW4Lu0crEj4lwp?=
 =?us-ascii?Q?zXypjuoCyitMuiExHsLboRb0qxiYcaFjHQap3uP53dmF6tYi7bUQ9IX/0zVr?=
 =?us-ascii?Q?JlGp9iIfR9Sl7qF4o9yVi2Y4oV8E7+UTeLOsMPxkrXIgMjw29EQDBHBKaqjE?=
 =?us-ascii?Q?YNncxE3Gks2DNHLqeyuqn79OpGPxbzSUjCmvlzi02xLIJI5y2p0m6TCijX6m?=
 =?us-ascii?Q?y3QcgDnZyTXpFp9VhU4sSPHxhjyXSGaAXFZvL0WQ2CTKtGbADnOpZT2xKpKn?=
 =?us-ascii?Q?2S2FiKtfX3K+TioVTe5+3c+R66khbvy6iTreUcM+nJlFlDqsRSVYeUkdDuDn?=
 =?us-ascii?Q?IdsPvThDnWEXFbHGlgzwD6bJLqJ8u0Ho5q+4TwY06mWH/iHi5BY7BDHyxaIH?=
 =?us-ascii?Q?8Yqg1lzI4muy/mMDKCYvM/s6/AdCVa1oAnM8e74Ri5YuXMROOstvcRnCR6OU?=
 =?us-ascii?Q?UqrGD2EaeDI1Jpbl39rePjdXYdYSILpCVE6pConq9AVmt3YU3T3rOeLF5KKc?=
 =?us-ascii?Q?RG96mUd5dUq6g/fL2n7fQzw0PQCzi+7T2RhEQV7Piw65wwM0OnZt8Jxm2yl2?=
 =?us-ascii?Q?9pHj68lPGSSEDeSCezU8Ucs+OV4DIW9V0l+4pdTAkkhm/+eN2f1u9iH4kPvw?=
 =?us-ascii?Q?5S6OeomQBjgVXIlTxA6JsMDPwFZo0L90El6hhrokf4nKwJZPplE/rsNMWdo1?=
 =?us-ascii?Q?fuVQhaGpRlHyS+NQuuEy4IYb8trl6KLZcyaew2nduoDUqSL6EsT9HaPr9+2g?=
 =?us-ascii?Q?WUyZUSVVFjj7U8JW0N5+HBXTThfppUZqpvzCAuGOcELo/0zDPjLLb5rfpgG1?=
 =?us-ascii?Q?NhtkEmYxCZHzdwZOv02WVCCv6KAdO4kyxbL0W588cl8kxLZKtc8FwHFMma3x?=
 =?us-ascii?Q?DPoIe2KkVp+UEI3ttWHJiwmKNkmV4wYKha8d24xRvAGcHL9VDtt4zXcBTJv8?=
 =?us-ascii?Q?15VVlp7/+hOZKYterGkrUuPu9n8ItDmbFJjUilfyvAqEfLYgTliFgpgv5k3d?=
 =?us-ascii?Q?0TaTAERYIArB812L6ZQcJNZOUp1roBCWlkauo8w6TFBj5t2j4edCd5CBF5Wh?=
 =?us-ascii?Q?gtr/smmLuYBSvs35NOIGGvTgHranohay8OKbbw7s/cq4eZbMg+dt2J5vTzXI?=
 =?us-ascii?Q?8mAq8A6ZgJwvKyxzRFG0qDp4FZR7N5n1XDTMPvjmCDleFMec/BLwr6X1SzmF?=
 =?us-ascii?Q?IrTGMj02/t0BF8XagCfOTf6mL1EZpvu5aAdxSYFbRDPUQAiDIAEosL8NUj1k?=
 =?us-ascii?Q?WpRJXcdapR9IYbZKIPlEO2qTADoTaWya2ai6jGdStCGCtEjEr/1qBcUGw7fd?=
 =?us-ascii?Q?e+71A7yWoYvviWP+gOu0RB79T1snJVmx11NG/79e/mrP/V8odKSU7RNvlwt2?=
 =?us-ascii?Q?t5f12AMTyUQtSHj52PXLa35gtX+xh133dX1/FLLFFC7evXi5mdKDZtQXgwGp?=
 =?us-ascii?Q?H+XmDYhUUHhE4nRTCVpD62sMY3O/GiKI4ePYEK8uwX9nOZwz3fHAo/bfIh2a?=
X-MS-Exchange-AntiSpam-MessageData-1: GVPbYmhkSvlwPQ==
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c6624a5-5368-403a-7071-08da33fdec00
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 09:58:10.7728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k4a5P+mU1jBw1+X5HjF2hqPWRh7vmmsuuMmDfK/NzTAIhEepWkjUQ9s+v4Etw/92V02vqrHinICm+ttjKIqfdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4574
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12.05.22 11:32, Zhou jie wrote:
> drivers:Modify the return value to void

Hi,

technically the patch is obviously correct. Yet, it is not a good idea.
write_mos_reg() can fail and hiding errors is not a good strategy.
You'd better propagate the error.

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver