Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] iommu: Remove unneeded NULL check in msm_iommu
Date:   Fri, 13 May 2022 16:42:26 +0800
Message-Id: <20220513084226.129437-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OgdZaRi1gqes0i9KFzw8h3OuKrSkp4mbDPMkY4MqueEfSrnK9y29HJukXTp5?=
 =?us-ascii?Q?boGUCUEwI1GOv/JKgkjHQS5L19871JpFMj4L88E48/XkdfY9gl7jXmoku0Rr?=
 =?us-ascii?Q?bb/WM6XLsPH2FQtXiQC2qGWSK5X+L5jZV6D4Xidgh3HKTapmr0tCfRHeAlD2?=
 =?us-ascii?Q?6QTIhSE8pbqcU4m74b0hZMdiEtl+886vbfIHWZoXFGtQXW3xmsMOgiwUUCiR?=
 =?us-ascii?Q?IeiYdXoNJvoRAgLwtkXVtLwKy6tSShNp74s14m/83t9Vcg0a+LCP1LcIzFf9?=
 =?us-ascii?Q?8XPmuS0RqgL5pPa3Kut/ahPCOrFsnzetVrch2xc2xxWL+aADuaAEDogqDAzA?=
 =?us-ascii?Q?1Jx7dwvMZn57e6qjFYkRfxevsiu/6DciZ93/jTKhWA2fjvEtw6JFI2GU5XwU?=
 =?us-ascii?Q?EvFxsFrYDMXeSONnifDA5nz10ktL/mMn88qoyeqvVGVlFuO1m4tePbMYhYeU?=
 =?us-ascii?Q?B2Pb03FpH5mGI/unXIckW0zd8dk6+usb+ultKe1P4MdQs82XQh0sQeIVW1UU?=
 =?us-ascii?Q?jXjzlMIEl5liimZAwTBt9VX86HSrL8gqEnfQwqOB+M4Hw1hvj8nVuwuRH958?=
 =?us-ascii?Q?9iaGVLMbUgg0SaKbiHpCCMjVu+ZhRZ+UhA8m9fSyQlKvbqFQwovpPdjO9cNC?=
 =?us-ascii?Q?pjgjMJWruEJcFfMzzLNFJbU79BgOhgLYM0xWvMYXokjGdUmsYLt6Rno9Ir1v?=
 =?us-ascii?Q?rZW3UYfNZNZV264ZivYo5soBVPBG775EcOUMgi5cOQnIuK5/89T7oTOrgO54?=
 =?us-ascii?Q?X0rSYWOc4W3cEz4Sxl06BlqPPIcr1HLGN+bVrBd0Y05uFKSysU+mRaoliXPJ?=
 =?us-ascii?Q?aKw1AvLxGF6WrETeARn3Sz2rMTsukU60Un2deAyrMh8D1MEQ0BPwmbY7xqpK?=
 =?us-ascii?Q?12XLndFUlgXeyfo6TIHGD/dbdZWKeo/hl7WWQEW5vg3SEENEp4OjsWOVAaDz?=
 =?us-ascii?Q?CexsaFlgtkLpAaMBPZWOvKplZmlE9AqNdhLR/vp5Y7tjlHEiFxStyduI9JxC?=
 =?us-ascii?Q?eEl1en3RpukpS7SG4YWkzEYtUwCPjX/lApU7DqcQS4ppVYbW6Y1A9EfZUITE?=
 =?us-ascii?Q?jsHj0vg5Fv1PyueNKkGGhH6YT1CkbdJhH33dPTTEuKYBl3wXFfJOzSHXf/he?=
 =?us-ascii?Q?ioeT2UARVJnoRXqyNcOaGh4Tny7iuqdFcbC/xOCX9rRIsYouV+Eoiqztadw0?=
 =?us-ascii?Q?l/s9htSVrsEmiGQPsiB8+jyA+qNIdLFImYI8v2ZnJp+4ndFOTtOtjlXRaq5N?=
 =?us-ascii?Q?e/twD4zL1VrFlDpwaOOlUP8OcOqRFWu+XoHSf3k5B1M170TzjS2nv72zvBZT?=
 =?us-ascii?Q?OhE1/FOrSSycHfcKl54QW8qS70NHleXJ4kemsUt2QZv9ZcgXVgQ/nvdg5F4v?=
 =?us-ascii?Q?4QLawkHnbnl3by5PyWT1dvf3kNKrW5u/yusmSpxTBsbeSHXXkakABRDNnvom?=
 =?us-ascii?Q?tNquJ2AM/iiYladaB7xr6how8YpI7w/3IY4wzC+aBkeIUILrqTwFPh5zRXAp?=
 =?us-ascii?Q?wn/tBsDi4XUEtdiNKoT25wVuQ84gub42/PVEwzu3Fcx+hRj+LdoqMqxYK2yG?=
 =?us-ascii?Q?nfDe9NuVHEDRDIbafQmDhjD5Yp/oEFWon0HcQKcDyI9DI3GtDUL6R9wJUj1v?=
 =?us-ascii?Q?ELFpl+yqzohrr6o8kBLKevp8T3Q/C23gMdczal7yfoKuo10oaxn/z9O/o/7G?=
 =?us-ascii?Q?vmwpJEmqnjmeryyF67gWse5llMJZ62oofJ4ZCCxi5WYn7iOPzXy9dg+smg8f?=
 =?us-ascii?Q?mGSYtWCdmw=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03164108-8c2f-4aaa-695b-08da34bc92ff
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3374.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 08:42:55.2929
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h2G0Cg7Y83ctaSNLdAEzjP6b0iGYEWIHRfbAvFfv0dnjHJMEW0uK+vhqc2zx1w61zajP5zvAMzDGiJQUGZ9+6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3368
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

clk_disable() already uses IS_ERR_OR_NULL to check NULL pointer.
Remove unneeded NULL check for iommu->clk here.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/iommu/msm_iommu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
index f09aedfdd462..c3ec2b7d33a5 100644
--- a/drivers/iommu/msm_iommu.c
+++ b/drivers/iommu/msm_iommu.c
@@ -70,8 +70,7 @@ static int __enable_clocks(struct msm_iommu_dev *iommu)
 
 static void __disable_clocks(struct msm_iommu_dev *iommu)
 {
-	if (iommu->clk)
-		clk_disable(iommu->clk);
+	clk_disable(iommu->clk);
 	clk_disable(iommu->pclk);
 }
 
-- 
2.35.1