Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 12 May 2022 10:30:13 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Kees Cook <keescook@chromium.org>
Cc:     Maninder Singh <maninder1.s@samsung.com>, pmladek@suse.com,
        rostedt@goodmis.org, senozhatsky@chromium.org,
        andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk,
        akpm@linux-foundation.org, wangkefeng.wang@huawei.com,
        v.narang@samsung.com, swboyd@chromium.org, ojeda@kernel.or,
        linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
        avimalin@gmail.com, atomlin@redhat.com, onkarnath.1@samsung.com
Subject: Re: [PATCH modules-next 1/1] kallsyms: enhance %pS/s/b printing when
 KALLSYSMS is disabled
Message-ID: <Yn1EJZOSdu9q/V4w@bombadil.infradead.org>
References: <CGME20220421041604epcas5p414cf2e851d1bd828a151dc6b2b004680@epcas5p4.samsung.com>
 <20220421041542.9195-1-maninder1.s@samsung.com>
 <202205111513.3AD646936@keescook>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202205111513.3AD646936@keescook>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Wed, May 11, 2022 at 03:25:14PM -0700, Kees Cook wrote:
> On Thu, Apr 21, 2022 at 09:45:42AM +0530, Maninder Singh wrote:
> > print module information when KALLSYMS is disabled.
> 
> I'd like this patch reverted from -next.
> - too many logical changes is a single patch
> - addition of dangerous API usage
> - duplicated logic (maybe? hard to review due to the changes)

Yanked out.

  Luis