Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <0b323f86-79e3-f219-58d2-0a48330b92e4@socionext.com>
Date:   Fri, 13 May 2022 15:51:57 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH] ARM: milbeaut: Fix refcount leak in m10v_smp_init
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Takao Orito <orito.takao@socionext.com>,
        Arnd Bergmann <arnd@arndb.de>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220512081554.28562-1-linmq006@gmail.com>
From:   Sugaya Taichi <sugaya.taichi@socionext.com>
In-Reply-To: <20220512081554.28562-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Thank you for the patch!

Acked-by: Sugaya Taichi <sugaya.taichi@socionext.com>


On 2022/05/12 17:15, Miaoqian Lin wrote:
> of_find_compatible_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: 9fb29c734f9e ("ARM: milbeaut: Add basic support for Milbeaut m10v SoC")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>   arch/arm/mach-milbeaut/platsmp.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-milbeaut/platsmp.c b/arch/arm/mach-milbeaut/platsmp.c
> index 3ea880f5fcb7..1f1ff21c7140 100644
> --- a/arch/arm/mach-milbeaut/platsmp.c
> +++ b/arch/arm/mach-milbeaut/platsmp.c
> @@ -53,6 +53,7 @@ static void m10v_smp_init(unsigned int max_cpus)
>   		return;
>   
>   	m10v_smp_base = of_iomap(np, 0);
> +	of_node_put(np);
>   	if (!m10v_smp_base)
>   		return;
>   
>