Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <2aeb7845-1dfe-c295-9fc9-38249e84f308@linaro.org>
Date:   Thu, 12 May 2022 12:12:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH V2 1/2] dt-bindings: rtc: Add TI K3 RTC description
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Andrew Davis <afd@ti.com>
References: <20220511002600.27964-1-nm@ti.com>
 <20220511002600.27964-2-nm@ti.com>
 <d7f124a7-a338-8ada-8d68-9434059db9fc@linaro.org>
 <20220511193838.o62nvhwfo4fgcg7l@overview>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220511193838.o62nvhwfo4fgcg7l@overview>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/05/2022 21:38, Nishanth Menon wrote:
> On 18:28-20220511, Krzysztof Kozlowski wrote:
>> On 11/05/2022 02:25, Nishanth Menon wrote:
> [...]
> 
>>
>> I didn't brought it earlier (I assumed you used existing RTC examples
>> for your schema): why this is not including generic rtc.yaml schema?
>> Isn't this a RTC?
> 
> Oversight, and I suppose I picked a bad example to emulate :(
> 
> I assume you mean adding:
> allOf:
>   - $ref: "rtc.yaml#"
> 
> Like this:
> https://gist.github.com/nmenon/0c326c92fbadecd042209c0078f0af99 ?

Yes plus you need to use unevaluatedProperties:false and remove
wakeup-source (it's coming from rtc.yaml).

Best regards,
Krzysztof