Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 12 May 2022 13:38:36 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Eugeniu Rosca <erosca@de.adit-jv.com>
Cc:     Alan Stern <stern@rowland.harvard.edu>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Rajat Jain <rajatja@google.com>, Andrew Lunn <andrew@lunn.ch>,
        Chris Chiu <chris.chiu@canonical.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Naveen kumar Sunkari <naveenkumar.sunkari@in.bosch.com>,
        Bhuvanesh Surachari <Bhuvanesh_Surachari@mentor.com>,
        Eugeniu Rosca <rosca.eugeniu@gmail.com>
Subject: Re: [PATCH] usb: hub: Simplify error and success path in
 port_over_current_notify
Message-ID: <YnzxvJ7/LGpu92bK@kroah.com>
References: <1652354127-3499-1-git-send-email-erosca@de.adit-jv.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1652354127-3499-1-git-send-email-erosca@de.adit-jv.com>
Precedence: bulk

On Thu, May 12, 2022 at 01:15:27PM +0200, Eugeniu Rosca wrote:
> From: Bhuvanesh Surachari <Bhuvanesh_Surachari@mentor.com>
> 
> kasprintf() returns NULL or valid pointer. Since kfree() can handle
> NULL pointer condition, simplify error and success paths in function
> port_over_current_notify() by removing multiple error path labels.
> 
> Signed-off-by: Bhuvanesh Surachari <Bhuvanesh_Surachari@mentor.com>
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> ---
>  drivers/usb/core/hub.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 1460857026e0..9ab8abf14790 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -5511,7 +5511,7 @@ static void hub_port_connect_change(struct usb_hub *hub, int port1,
>  /* Handle notifying userspace about hub over-current events */
>  static void port_over_current_notify(struct usb_port *port_dev)
>  {
> -	char *envp[3];
> +	char *envp[3] = { NULL, NULL, NULL };
>  	struct device *hub_dev;
>  	char *port_dev_path;
>  
> @@ -5533,15 +5533,13 @@ static void port_over_current_notify(struct usb_port *port_dev)
>  	envp[1] = kasprintf(GFP_KERNEL, "OVER_CURRENT_COUNT=%u",
>  			port_dev->over_current_count);
>  	if (!envp[1])
> -		goto exit;
> +		goto exit_path;

No need to rename this, right?

>  
> -	envp[2] = NULL;
>  	kobject_uevent_env(&hub_dev->kobj, KOBJ_CHANGE, envp);
>  
> +exit_path:
>  	kfree(envp[1]);
> -exit:

Move this up one line?

thanks,

greg k-h