Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1026395iob; Fri, 13 May 2022 20:08:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYgndcWGSNUVJYRWw27AYEhPn6KLP+N5xzuqR/4ppVvD+wbyiHnZa85lDIoFAmXD1KdSkO X-Received: by 2002:a1c:acc6:0:b0:38e:b184:7721 with SMTP id v189-20020a1cacc6000000b0038eb1847721mr7017431wme.94.1652497730128; Fri, 13 May 2022 20:08:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652497730; cv=none; d=google.com; s=arc-20160816; b=MF4CfTNVbufljCs2CnA6mqNlu7S6kGUP8qNnORW3hmXE0BU1ygENCHUuEzUJPJ4kdY WCAd+6RR2EhsfoW+WV57dizNP9GTj6M/RkX6IQEPgNe/8JsRSITzRlJe69OG2f3oxhn+ FYUCpDRf6RLMp/5ZDP8t8xtJQm2jH3ip9htYEjfEPkwHMgrhjJVtGzb3hmN/y/22In7z lqRaGpHOr0HhNp/9bhpu6mniggSMZ5sHJ9qp551pqzM/UBn+Xr6CGEIxvV5qZIr2aG16 OlnDtqH3ScFTkyZPFBTvC6yftMVpCIeDTHgLr4T1U3q37jeZoM3CfHOkJ4RuQ4RgL6WA CkUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sJnARy5TGz4NpCzf3IzEC2y86PKjT72on0U1COCcsiY=; b=lfNDufGn/XIz3y2RBByOzaF8LvuwBytf0seAo7uzcMNLuPF81UU6tnmFfjbZMeACZX jH4IO5kDKm7PpJhLI+x7QqGHWKaLfXSChe6qAcUpIB8mRfFINfZRx9qwkI+6+Daw4F8N 6ks3JZsYs/STBG4rkEv71RN+peL2sm/etPGERW/TYcqovcrydkvN0r14LxnRZTx+OLxG lLVnCLRmJoCSQ3/BEHyX/Hl30vmryJuQEc4Hxy6S7d2CrYGqZemTwfsNqA//fGX/h4Lc YRB8ApHGM1R5RcGO74e0oSJRMfi/szIwGSNGAsBH6eGGw3TWiOWUWEqNqSYfRLmyI8bJ 94Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=La+cZ0Pi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id az28-20020adfe19c000000b0020ac7a84cb7si3752696wrb.441.2022.05.13.20.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 20:08:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=La+cZ0Pi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 933CE3C1B5C; Fri, 13 May 2022 16:49:55 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376476AbiEMCQw (ORCPT + 99 others); Thu, 12 May 2022 22:16:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347937AbiEMCQu (ORCPT ); Thu, 12 May 2022 22:16:50 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0803C4BFF3 for ; Thu, 12 May 2022 19:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sJnARy5TGz4NpCzf3IzEC2y86PKjT72on0U1COCcsiY=; b=La+cZ0PiXhgVAZf9GrKw0MGt13 A/qJeOL+7cPMG0h4QGK1tPteCkZSWazDjuWDc+XVBShe/Fe2p+nBRAyYYbK5QdHjE8KXIXze5GhX2 B/cmHpiiqGGA5iy96ptFNHXE+Aw38ny02uI0DCYoolfcplF11yeT0KmQ3bB4k+1w2+aFwMncosdXP kixjpgxm2+zAdWt+16cG++hFBwgMIjkwTEoBtGIkcyI/BDKkK5WFc6wxKY2ngUpoWzlIRCe37ZItb LLV2HWk10fW+59HOfQjLAr9z0ziBWLeIgCt22gKkEs/karD3ZSLdB7Itz/qgN+Hfqu49IdfKxrztw +got7fdg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1npKrE-006xVl-Lc; Fri, 13 May 2022 02:16:44 +0000 Date: Fri, 13 May 2022 03:16:44 +0100 From: Matthew Wilcox To: Yang Shi Cc: songmuchun@bytedance.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: rmap: use the correct parameter name for DEFINE_PAGE_VMA_WALK Message-ID: References: <20220512174551.81279-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512174551.81279-1-shy828301@gmail.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2022 at 10:45:50AM -0700, Yang Shi wrote: > The parameter used by DEFINE_PAGE_VMA_WALK is _page not page, fix the > parameter name. It didn't cause any build error, it is probably because > the only caller is write_protect_page() from ksm.c, which pass in page. > > Fixes: 2aff7a4755be ("mm: Convert page_vma_mapped_walk to work on PFNs") > Signed-off-by: Yang Shi Oops. Reviewed-by: Matthew Wilcox (Oracle)