Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <b128ed0f-08f8-2742-e22c-20cc5870a61c@linux-m68k.org>
Date:   Fri, 13 May 2022 09:57:43 +1000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 4/4] m68knommu: allow elf_fdpic loader to be selected
Content-Language: en-US
To:     linux-m68k@vger.kernel.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org, dalias@libc.org
References: <20220512230602.1408871-1-gerg@linux-m68k.org>
From:   Greg Ungerer <gerg@linux-m68k.org>
In-Reply-To: <20220512230602.1408871-1-gerg@linux-m68k.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 13/5/22 09:06, Greg Ungerer wrote:
> The m68k architecture code is capable of supporting the binfmt_elf_fdpic
> loader, so allow it to be configured. It is restricted to nommu
> configurations at this time due to the MMU context structures/code not
> supporting everything elf_fdpic needs when MMU is enabled.
> 
> Link: https://lore.kernel.org/linux-m68k/20220428033319.239341-1-gerg@linux-m68k.org/
> Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
> ---
>   fs/Kconfig.binfmt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> v2: remove superfluous surrounding "(" ")"

If no one has any objections I can carry this in the m68knommu
git tree with the rest of the series.

Regards
Greg


> diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt
> index 21c6332fa785..fb325b3aa4b0 100644
> --- a/fs/Kconfig.binfmt
> +++ b/fs/Kconfig.binfmt
> @@ -58,7 +58,7 @@ config ARCH_USE_GNU_PROPERTY
>   config BINFMT_ELF_FDPIC
>   	bool "Kernel support for FDPIC ELF binaries"
>   	default y if !BINFMT_ELF
> -	depends on (ARM || (SUPERH && !MMU))
> +	depends on ARM || ((M68K || SUPERH) && !MMU)
>   	select ELFCORE
>   	help
>   	  ELF FDPIC binaries are based on ELF, but allow the individual load