Subject: Re: [patch] make pit clocksource continuous
From: Thomas Gleixner <tglx@linutronix.de>
Reply-To: tglx@linutronix.de
To: Stas Sergeev <stsp@aknet.ru>
Cc: Daniel Walker <dwalker@mvista.com>,
       Linux kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <4646D493.9000309@aknet.ru>
References: <46464B5C.2080302@aknet.ru>
	 <1179040612.22481.237.camel@localhost.localdomain>
	 <4646D493.9000309@aknet.ru>
Content-Type: text/plain
Date: Sun, 13 May 2007 16:54:53 +0200
Message-Id: <1179068094.22481.248.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1344
Lines: 40

On Sun, 2007-05-13 at 13:04 +0400, Stas Sergeev wrote:
> Hello.
> 
> Thomas Gleixner wrote:
> > The PIT can only be used as a clock source, when it is in periodic mode,
> > but it is never continuous. If we miss one PIT interrupt the time
> > keeping is hosed.

> OK, thank you and Daniel for the explanations
> about the flag, but now to the problem.
> Before hrtimer_switch_to_hres() is called,
> the check for timekeeping_is_continuous() is
> performed in tick_ckeck_oneshot_change(), and
> that check fails (by adding a flag I compel it
> to succeed).

It succeeds, but it does not work correctly, because your time keeping
is unreliable.

>  With that check failing,
> hrtimer_switch_to_hres() is never called, and
> the hrtimers do not work. That's why I posted
> that patch, but what would be the right way
> of getting the hrtimers to work?
> /proc/timer_list lists only the pit timesource.
> If I enable lapic then it is also listed, yet
> it doesn't help at all.

You need either pm_timer or hpet in order to switch to highres /
dynticks. Are those enabled in the kernel config ?

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/