Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220509121409.529788-1-Jason@zx2c4.com> <20220509121409.529788-2-Jason@zx2c4.com>
 <Yn35k+yyrvgAt3tb@owl.dominikbrodowski.net> <Yn4xLowv+farg814@zx2c4.com> <d0dc54cecff5400d97f877676d7f11b1@AcuMS.aculab.com>
In-Reply-To: <d0dc54cecff5400d97f877676d7f11b1@AcuMS.aculab.com>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Fri, 13 May 2022 14:02:39 +0200
Message-ID: <CAHmME9pN_N_fG6k5gFB8mwrEPn1W-Zy54AmA3VSSvrkQyc3PvA@mail.gmail.com>
Subject: Re: [PATCH 2/2] random: move initialization out of reseeding hot path
To:     David Laight <David.Laight@aculab.com>
Cc:     Dominik Brodowski <linux@dominikbrodowski.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi David,

On Fri, May 13, 2022 at 1:38 PM David Laight <David.Laight@aculab.com> wrote:
>
> From: Jason A. Donenfeld
> > Sent: 13 May 2022 11:22
> >
> > On Fri, May 13, 2022 at 08:24:19AM +0200, Dominik Brodowski wrote:
> > > > - if (!crng_ready()) {
> > > > -         crng_init = CRNG_READY;
> > > > -         finalize_init = true;
> > > > - }
> > > > + crng_init = CRNG_READY;
> > >
> > > Why unconditionally
> >
> > To avoid a useless branch.
>
> Are you now dirtying a cache line that would
> otherwise be clean?

Fair enough. I'll keep the branch.

Jason