Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Linus Walleij <linus.walleij@linaro.org>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] ata: Remove unneeded ERROR check before clk_disable_unprepare
Date:   Fri, 13 May 2022 15:55:54 +0800
Message-Id: <20220513075554.127677-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uEYYVfdizEAIaPd90kpYJDizMdFb+5FUaOH1gPAn2v6jfG+sK4dGqrOd/QWq?=
 =?us-ascii?Q?YSeRm/JXsVJcRhS03yn+Pn5jZt7lfJe6r9fzImV9tkxRDrDKvvgrPkJ20hIj?=
 =?us-ascii?Q?K+EIK3fCsbXYEvy7qkJRzDGPagt1Rdom0ahlMDUUFjYPrV9+Irm/jJnFsreY?=
 =?us-ascii?Q?0MHNFX/42NpeaQSeJCRXKq4uYoAyIYrk3idcMvjpxlqhJiJ/hTvUFREngBXl?=
 =?us-ascii?Q?KjbLr5dF3WEQCXwRtnf5GOIbjiLlrMsf1fqOJLswaf31NMbBYVnd9EFU4koZ?=
 =?us-ascii?Q?WSak0udKcrLNSpovrwlUfY+82FFSRrc55o1WwOt0PeaMZ9TfapwRnqUDGuuL?=
 =?us-ascii?Q?gl4M6FhwkeDNiEiwfIFVX0jd0X/7Kf8HGeZsrAfVOdwfZrKgGVZpe8O98Zka?=
 =?us-ascii?Q?w0n8MXXckv+bHnZTKrN/qA4/2/TYj1r3E4tsoeziNA4IiccqibdHTelHJntx?=
 =?us-ascii?Q?mLJV9gxRbWgvRRL+GhaBbil1nzzrrTo+5cNl4KDWbjKQtuTCwQEM4Lzmw5JD?=
 =?us-ascii?Q?kW8QlEpPhd6EaqOdU8AptKegb34/8f6atjUTomnQ+2sN+22Wtv5vp7E06SAL?=
 =?us-ascii?Q?AoqyOSwb4QsEVTjhUWk51pQa3BkY40sGThQrA5c5CXro/3rYbWUOHCh0citK?=
 =?us-ascii?Q?da9Pz1rGhMdOwjbhYqJFekvl3hxUZr7j7ekQx7NECLEMhk3ZBsbOOWJiTTIJ?=
 =?us-ascii?Q?yTIk9ZSSTjjnl5XIEKvfQb7IEesVee2PBSEaOfUgsTwXHo98XBS7McnFn381?=
 =?us-ascii?Q?oBo2sSe+MhSGwpscJNXqpGsSV8u3uVVyWRg5vbT2BO5XzA/kLO2umnDhAEIp?=
 =?us-ascii?Q?QHUJ/nCkzugBBd2hmK/9QxKmb3L945O+suixXNbra9wbyoEwUcd4+RISmAUL?=
 =?us-ascii?Q?x1QhbvWNU4q0Q6lMdRcK6lpI2vJYelwvacK1X2/LailOc0QW20dgylo1dZYU?=
 =?us-ascii?Q?njYocTkmzo/R2Ux4bYMA6U5L/AGl6Vqc9rbArQ/SaTkN2Nj1G7ih7DLaON2d?=
 =?us-ascii?Q?uQqtF38a5W081a5YkuUdC7CIliPfhQkIP+QpZnKz3JvITUhZ0bBo2rpF26Uk?=
 =?us-ascii?Q?Npo5Lg/bHffNOdCFTUD+QYZsEK2CSX2vecCKXWdMQyiCWQXruiO9qpyf01Wz?=
 =?us-ascii?Q?kjL6tVxcxOhmAFbk85XI8suMR/aFmwQNX3sXWzGLkNXAKIHAAVMfC12XKkgE?=
 =?us-ascii?Q?e/aCnnmVT9l+/SvP195IrgMWG3MFz9ZqZInWDFybp6AcnYTFylFtEELn35SS?=
 =?us-ascii?Q?BTgWbrPqgGuQ4yde7YIi0X+XzTXNIAsZG/deg4mgIa6e40vaqJmVdpei8SoY?=
 =?us-ascii?Q?/6vxw5mX9HUyB1NdZxq4g0EhwjtYXfpPin2ujrqRA0AC7CHIhIGzoL1XMTjy?=
 =?us-ascii?Q?SW/1mbOI+FJvAATz4FxiiD19Hj6SqUG0pwc49KG+iVDM2PGw8yfHCCXXA7hx?=
 =?us-ascii?Q?W4qZAMgCsroZjh7vVF3nfGwlVv3SLHEElMIxksMrQ0gAE/zkrWBqL13DH0yG?=
 =?us-ascii?Q?tqK1LO0X68sTz7FMv5hxJufvfpkZrAIeE+boLbuvuyvHs7antovha/rL4JTR?=
 =?us-ascii?Q?eatFXAV+gB11E+qmhbl3vpPYkubezfTkEc0wFj8vLsmxQzVHRVZwGY59zd75?=
 =?us-ascii?Q?YMJ4xEQb5owXAlzA2ZkrlVGaU5SVl6nPb4nU7SSXywp6O0Tc3oI+pYcxUpcj?=
 =?us-ascii?Q?kV7mNzfAy5xiI4lnOqxfiYpSe+OToXIayu73OvxHkpP5vl/h4i39mMeyptz1?=
 =?us-ascii?Q?hjY4CVsa2w=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54530617-c08c-42d4-2784-08da34b60913
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3374.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 07:56:07.0882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jFAw8owzDgGbYACR4ajKz7PNwVTbnWBsknpKDoMlvXLkfnnNm24huivYi4nGC/wrkBOmGFnOfhurUMEUoe52xQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB3495
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ERROR check is already in clk_disable() and clk_unprepare() by using
IS_ERR_OR_NULL. Remove unneeded ERROR check for ftide->pclk here.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/ata/pata_ftide010.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/ata/pata_ftide010.c b/drivers/ata/pata_ftide010.c
index 2e35505b683c..0117df0fe3c5 100644
--- a/drivers/ata/pata_ftide010.c
+++ b/drivers/ata/pata_ftide010.c
@@ -536,8 +536,8 @@ static int pata_ftide010_probe(struct platform_device *pdev)
 	return 0;
 
 err_dis_clk:
-	if (!IS_ERR(ftide->pclk))
-		clk_disable_unprepare(ftide->pclk);
+	clk_disable_unprepare(ftide->pclk);
+
 	return ret;
 }
 
@@ -547,8 +547,7 @@ static int pata_ftide010_remove(struct platform_device *pdev)
 	struct ftide010 *ftide = host->private_data;
 
 	ata_host_detach(ftide->host);
-	if (!IS_ERR(ftide->pclk))
-		clk_disable_unprepare(ftide->pclk);
+	clk_disable_unprepare(ftide->pclk);
 
 	return 0;
 }
-- 
2.35.1