Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 11 May 2022 14:25:26 -0700
From:   Kees Cook <keescook@chromium.org>
To:     Florian Weimer <fweimer@redhat.com>
Cc:     Andy Lutomirski <luto@kernel.org>, x86@kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/vsyscall: Remove CONFIG_LEGACY_VSYSCALL_EMULATE
Message-ID: <202205111424.DEB0E3418@keescook>
References: <898932fe61db6a9d61bc2458fa2f6049f1ca9f5c.1652290558.git.luto@kernel.org>
 <202205111104.464A6619@keescook>
 <87k0ardigv.fsf@oldenburg.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87k0ardigv.fsf@oldenburg.str.redhat.com>
Precedence: bulk

On Wed, May 11, 2022 at 08:36:48PM +0200, Florian Weimer wrote:
> * Kees Cook:
> 
> > On Wed, May 11, 2022 at 10:38:53AM -0700, Andy Lutomirski wrote:
> >> CONFIG_LEGACY_VSYSCALL_EMULATE is, as far as I know, only needed for the
> >> combined use of exotic and outdated debugging mechanisms with outdated
> >> binaries.  At this point, no one should be using it.  We would like to
> >> implement dynamic switching of vsyscalls, but this is much more
> >> complicated to support in EMULATE mode than XONLY mode.
> >> 
> >> So let's force all the distros off of EMULATE mode.  If anyone actually
> >> needs it, they can set vsyscall=emulate, and we can then get away with
> >> refusing to support newer security models if that option is set.
> >> 
> >> Cc: x86@kernel.org
> >> Cc: Kees Cook <keescook@chromium.org>
> >> Cc: Florian Weimer <fweimer@redhat.com>
> >> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> >
> > Sounds legit! Can we switch the default to "none" while we're at it?
> 
> I think that's a userspace ABI break?
> 
> I do not have a *very* strong opinion about this.  For one thing, it
> would be handy example to have that such deliberate  do actually
> happen. 8-)

Right, I'm just suggesting switch the Kconfig default, so systems that
don't care will get that setting, and systems that do care can still
pick what they need.

(But yes, a separate patch, etc)

-- 
Kees Cook