Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934386AbXEMQLU (ORCPT ); Sun, 13 May 2007 12:11:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757745AbXEMQLJ (ORCPT ); Sun, 13 May 2007 12:11:09 -0400 Received: from hancock.steeleye.com ([71.30.118.248]:34193 "EHLO hancock.sc.steeleye.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757572AbXEMQLI (ORCPT ); Sun, 13 May 2007 12:11:08 -0400 Subject: Re: why does x86 "make defconfig" build a single, lonely module? From: James Bottomley To: Dave Jones Cc: "Robert P. J. Day" , Linux Kernel Mailing List , linux-scsi@vger.kernel.org In-Reply-To: <20070513160608.GA29024@redhat.com> References: <20070513160608.GA29024@redhat.com> Content-Type: text/plain Date: Sun, 13 May 2007 11:10:55 -0500 Message-Id: <1179072655.3723.42.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1524 Lines: 47 On Sun, 2007-05-13 at 12:06 -0400, Dave Jones wrote: > On Sun, May 13, 2007 at 11:22:55AM -0400, Robert P. J. Day wrote: > > > > not a big deal, but is there a reason that a "make defconfig" on my > > x86 system ends up selecting and building a single module? > > > > Building modules, stage 2. > > MODPOST 1 modules > > CC drivers/scsi/scsi_wait_scan.mod.o > > LD [M] drivers/scsi/scsi_wait_scan.ko > > > > is there something special about that module? just curious. > > My guess is that someone was paranoid and wanted not to have > to answer a zillion "my machine won't boot any more" questions > when async scsi scanning was added. > This might further clarify.. > > --- > > The scsi_wait_scan module is only really useful if async scanning > is enabled. > > Signed-off-by: Dave Jones > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index e62d23f..0f6c370 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -244,7 +244,7 @@ config SCSI_SCAN_ASYNC > config SCSI_WAIT_SCAN > tristate > default m > - depends on SCSI > + depends on SCSI_SCAN_ASYNC No. SCSI_SCAN_ASYNC is a bool ... if you depend on it, you'll force the wait scan to be built in, which isn't the idea at all. James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/