Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     Mark Brown <broonie@kernel.org>,
        linux-spi@vger.kernel.org (open list:SPI SUBSYSTEM),
        linux-kernel@vger.kernel.org (open list)
Cc:     zhengkui_guo@outlook.com, Guo Zhengkui <guozhengkui@vivo.com>
Subject: [PATCH] drivers: spi: spi-au1550: replace ternary operator with min()
Date:   Fri, 13 May 2022 21:03:33 +0800
Message-Id: <20220513130333.58379-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1jh/lPyUlWUboA7H9R6AjdmZ/Jjkvz1ub2b69Oo6rQ8nGMNvhLuu0NMRGijd?=
 =?us-ascii?Q?QUvXGZ5QqKWwti2Pr6+3pTjEEaWat7etsuCNz56tduflMbcFD9SqZr9++eh1?=
 =?us-ascii?Q?YHuL4YDf9mPJX8G/DbjuhKqO6AF/jX5i/Fo/n9zD5OaBN+EcYB3NDKBBMT5S?=
 =?us-ascii?Q?o/5RARJffnlo5BBeZMzE1m3AMAmx1uuibgV401gE2tFDkJ7gmQsRFyVl/csH?=
 =?us-ascii?Q?Yp9MkXn7/gy2h1cVonc2QbDj1MeXhcWhJdVCkhxQiE4dyVWjQuwMK4YfoJXP?=
 =?us-ascii?Q?hzEttb+uavJO6eS1YWDlng9tISz+MU6gaSpSFUV9q1lpmNRtccjcGS/3gbLo?=
 =?us-ascii?Q?lHm04sXntgEZ6jHWLBWkIcy1uZfxSUInlg4cMrK23IFIompORQTJdJJt6Ipp?=
 =?us-ascii?Q?XUnSe5r+mRCyLgxXcqkwzGbZaqiVh0lx7tGbHHh3wBxX7uiJSy+2PKia3ydb?=
 =?us-ascii?Q?jixlu/tZ/1yU6EcVnPd58+F9xmXrLgt3Z8ysH7hnvQhAAsbTBc49lmzjOR1y?=
 =?us-ascii?Q?jJx77T1VwfUdNlDWKsorI8mzBXI7470ZfhM4v7OnEhpGhd7cKcIM6+0niupe?=
 =?us-ascii?Q?xBgCf9mTk78lvyV0bkojLnIILTaF/orAGA4aUjm9h2nSfjVENmxqtyltnXIR?=
 =?us-ascii?Q?YJTkdy8OBqD3u3oIDk814lgo9dpF5m8l+l+KJYD+pqw8fsERt2NDELCvjMVJ?=
 =?us-ascii?Q?t+4GX/Rt+XiYtlVA8fAWL/LyxW2OpGuO0XneiodreLABgYhotYYs4xR2m7/L?=
 =?us-ascii?Q?IXJ0UUpHJdQe3Bkb7JqNRfjUMDMKkGF+OVFoYfuvtsZurMJDgPbBQUdYdYtv?=
 =?us-ascii?Q?4ZmW/iubN5RrP/Ph4xft8YuzW9O+MgO0z91O+BNHFjcmZpNvGyvOQG5apaZh?=
 =?us-ascii?Q?9aXsdJ8+bgy9o8862Fxu+oIKwcHRLvQw9u5gyUkth4fXlKHhvNPfvZTzInGm?=
 =?us-ascii?Q?x76jjDCxqFL/k2rnUzxVdsdanHH+P5KuY8gUqx8CxNIw+Z8UhAJQuBSyPwOa?=
 =?us-ascii?Q?vYtGMS2Jzhk3zWoOwmDWjQ1uKT5Y0mAD1/QZviRdhe3eaWWmnDj8BG9bkwal?=
 =?us-ascii?Q?7qQ9InUYyUSeML+fPNj87CBsVBUz94Y3SvntRE63HS3bz8hb679C7utVxhGw?=
 =?us-ascii?Q?TcGLAxWBMQp4OTpPQA8zwKaO+lOLOTQhHML/4tjZukfxHkBv9bpiJ8jSdaVn?=
 =?us-ascii?Q?ortFjxLax86Vk2zze+98NNFcsV71iu8ANmBINM84lOq7K3VfjpBhtkBtbUmR?=
 =?us-ascii?Q?U0SsDxBvwVcdmMWH4SrD/yII12wcAQ9IyyjksvLia4YFMQHEhxQBBz4ztuYu?=
 =?us-ascii?Q?sAhOB14aRV5CBlP7dTu1fLICUqTClZ4lA+yKT3q2oUrhu2ZQKjyp6PK+0CRe?=
 =?us-ascii?Q?fMQPjqErPB521eEtJmZuKL4IqVoq+AwvWYZfBvRAoERWoccPvzmujTsnqGxu?=
 =?us-ascii?Q?a0RnxzQCvanvGV1wwD0//fjunzPB9c9VLb2e704n4s5bcsq4N6arzH+MGwNh?=
 =?us-ascii?Q?dLhxVT2Y7c7XzXjJ/Y+DXZZlwrTnsR/94MXLiV3A/cPZaHMuMbypWvunnYUO?=
 =?us-ascii?Q?+eI+S4vKoa2Qz9+CQM2gZ9fkLTrLOau6i+mZOuShR5dvqvGy/tw8STowZl55?=
 =?us-ascii?Q?fmzL+AN1RFCmF79vQp/mXOOgBPzR2SgAPCV88N+mmhpqiqgj5zpfAn7p7svo?=
 =?us-ascii?Q?DnPM418ZV5q4xaUnK8IuVXpCn50BaUYA3Ps/p4PQHQs16VyyLUT1lwEl+lm6?=
 =?us-ascii?Q?H5VwhP/Z9Q=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbf83d4e-8479-4b19-63f8-08da34e10ba3
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 13:03:59.7327
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bFgK5SMjJ6O9YDtXymZUXJhr/wN8KzVAdCGt1zb6Oc0cl8ahde8HfXvj0SJ93qG16uREV2BQOpTTWfFtioZpaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB3733
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix the following coccicheck warnings:

drivers/spi/spi-au1550.c:408:21-22: WARNING opportunity for min()
drivers/spi/spi-au1550.c:542:21-22: WARNING opportunity for min()

min() macro is defined in include/linux/minmax.h. It avoids multiple
evaluations of the arguments when non-constant and performs strict
type-checking.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 drivers/spi/spi-au1550.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-au1550.c b/drivers/spi/spi-au1550.c
index 4b59a1b1bf7e..e008761298da 100644
--- a/drivers/spi/spi-au1550.c
+++ b/drivers/spi/spi-au1550.c
@@ -405,7 +405,7 @@ static int au1550_spi_dma_txrxb(struct spi_device *spi, struct spi_transfer *t)
 		dma_unmap_single(hw->dev, dma_tx_addr, t->len,
 			DMA_TO_DEVICE);
 
-	return hw->rx_count < hw->tx_count ? hw->rx_count : hw->tx_count;
+	return min(hw->rx_count, hw->tx_count);
 }
 
 static irqreturn_t au1550_spi_dma_irq_callback(struct au1550_spi *hw)
@@ -539,7 +539,7 @@ static int au1550_spi_pio_txrxb(struct spi_device *spi, struct spi_transfer *t)
 
 	wait_for_completion(&hw->master_done);
 
-	return hw->rx_count < hw->tx_count ? hw->rx_count : hw->tx_count;
+	return min(hw->rx_count, hw->tx_count);
 }
 
 static irqreturn_t au1550_spi_pio_irq_callback(struct au1550_spi *hw)
-- 
2.20.1