Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220513062045.840780-1-pengfuyuan@kylinos.cn>
In-Reply-To: <20220513062045.840780-1-pengfuyuan@kylinos.cn>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 13 May 2022 12:55:15 -0400
Message-ID: <CADnq5_P+ibMk_z69CxH_Q60YL259US9f7uv3MDnMgU7pX47MuQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: Remove macro DC_DEFAULT_LOG_MASK
To:     pengfuyuan <pengfuyuan@kylinos.cn>
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>, xinhui pan <Xinhui.Pan@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, May 13, 2022 at 3:20 AM pengfuyuan <pengfuyuan@kylinos.cn> wrote:
>
> [Why]
> The DC_DEFAULT_LOG_MASK macro has not been used for a long time, so remove it.

I'm sure there are lots of macros in the driver that are not used at
the moment.  Any particular reason to remove it?  DC_MIN_LOG_MASK
doesn't appear to be used at the moment either.

Alex

>
> Signed-off-by: pengfuyuan <pengfuyuan@kylinos.cn>
> ---
>  .../drm/amd/display/include/logger_types.h    | 33 -------------------
>  1 file changed, 33 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h b/drivers/gpu/drm/amd/display/include/logger_types.h
> index f093b49c5e6e..1b38cfc41718 100644
> --- a/drivers/gpu/drm/amd/display/include/logger_types.h
> +++ b/drivers/gpu/drm/amd/display/include/logger_types.h
> @@ -131,37 +131,4 @@ enum dc_log_type {
>  #define DC_MIN_LOG_MASK ((1 << LOG_ERROR) | \
>                 (1 << LOG_DETECTION_EDID_PARSER))
>
> -#define DC_DEFAULT_LOG_MASK ((1ULL << LOG_ERROR) | \
> -               (1ULL << LOG_WARNING) | \
> -               (1ULL << LOG_EVENT_MODE_SET) | \
> -               (1ULL << LOG_EVENT_DETECTION) | \
> -               (1ULL << LOG_EVENT_LINK_TRAINING) | \
> -               (1ULL << LOG_EVENT_LINK_LOSS) | \
> -               (1ULL << LOG_EVENT_UNDERFLOW) | \
> -               (1ULL << LOG_RESOURCE) | \
> -               (1ULL << LOG_FEATURE_OVERRIDE) | \
> -               (1ULL << LOG_DETECTION_EDID_PARSER) | \
> -               (1ULL << LOG_DC) | \
> -               (1ULL << LOG_HW_HOTPLUG) | \
> -               (1ULL << LOG_HW_SET_MODE) | \
> -               (1ULL << LOG_HW_RESUME_S3) | \
> -               (1ULL << LOG_HW_HPD_IRQ) | \
> -               (1ULL << LOG_SYNC) | \
> -               (1ULL << LOG_BANDWIDTH_VALIDATION) | \
> -               (1ULL << LOG_MST) | \
> -               (1ULL << LOG_DETECTION_DP_CAPS) | \
> -               (1ULL << LOG_BACKLIGHT)) | \
> -               (1ULL << LOG_I2C_AUX) | \
> -               (1ULL << LOG_IF_TRACE) | \
> -               (1ULL << LOG_HDMI_FRL) | \
> -               (1ULL << LOG_SCALER) | \
> -               (1ULL << LOG_DTN) /* | \
> -               (1ULL << LOG_DEBUG) | \
> -               (1ULL << LOG_BIOS) | \
> -               (1ULL << LOG_SURFACE) | \
> -               (1ULL << LOG_DML) | \
> -               (1ULL << LOG_HW_LINK_TRAINING) | \
> -               (1ULL << LOG_HW_AUDIO)| \
> -               (1ULL << LOG_BANDWIDTH_CALCS)*/
> -
>  #endif /* __DAL_LOGGER_TYPES_H__ */
> --
> 2.25.1
>