Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 12 May 2022 17:44:31 +0200
From:   Eugeniu Rosca <erosca@de.adit-jv.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Eugeniu Rosca <erosca@de.adit-jv.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Rajat Jain <rajatja@google.com>, Andrew Lunn <andrew@lunn.ch>,
        Chris Chiu <chris.chiu@canonical.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Naveen kumar Sunkari <naveenkumar.sunkari@in.bosch.com>,
        Bhuvanesh Surachari <Bhuvanesh_Surachari@mentor.com>,
        Eugeniu Rosca <rosca.eugeniu@gmail.com>
Subject: Re: [PATCH] usb: hub: Simplify error and success path in
 port_over_current_notify
Message-ID: <20220512154431.GA4536@lxhi-065>
References: <1652354127-3499-1-git-send-email-erosca@de.adit-jv.com>
 <YnzxvJ7/LGpu92bK@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YnzxvJ7/LGpu92bK@kroah.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

Dear Greg,

On Do, Mai 12, 2022 at 01:38:36 +0200, Greg Kroah-Hartman wrote:
> On Thu, May 12, 2022 at 01:15:27PM +0200, Eugeniu Rosca wrote:
> > From: Bhuvanesh Surachari <Bhuvanesh_Surachari@mentor.com>

[..]

> >  	if (!envp[1])
> > -		goto exit;
> > +		goto exit_path;
> 
> No need to rename this, right?
> 
> >  
> > -	envp[2] = NULL;
> >  	kobject_uevent_env(&hub_dev->kobj, KOBJ_CHANGE, envp);
> >  
> > +exit_path:
> >  	kfree(envp[1]);
> > -exit:
> 
> Move this up one line?

Thank you for your comments. Much appreciated.

Please, find the updated version at:
https://lore.kernel.org/linux-usb/1652369834-4480-1-git-send-email-erosca@de.adit-jv.com

Best regards,
Eugeniu