Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220511120532.2228616-1-hca@linux.ibm.com> <20220511120532.2228616-4-hca@linux.ibm.com>
 <Yn1CLcsu9I0M8IEM@osiris>
In-Reply-To: <Yn1CLcsu9I0M8IEM@osiris>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Thu, 12 May 2022 11:00:31 -0700
Message-ID: <CAKwvOdmSBNsA7C2ZCGDEmuxCituSQ=HPJx=9+AsBAOYfkSZRPA@mail.gmail.com>
Subject: Re: [PATCH 3/8] s390/entry: shorten OUTSIDE macro
To:     Heiko Carstens <hca@linux.ibm.com>
Cc:     Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Jonas Paulsson <paulsson@linux.vnet.ibm.com>,
        Ulrich Weigand <ulrich.weigand@de.ibm.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Alexander Egorenkov <egorenar@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Andreas Krebbel <krebbel@linux.ibm.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, May 12, 2022 at 10:22 AM Heiko Carstens <hca@linux.ibm.com> wrote:
>
> On Wed, May 11, 2022 at 02:05:27PM +0200, Heiko Carstens wrote:
> > Since the minimum architecture level has been raised to z10 a shorter
> > instruction sequence can be used to implement the OUTSIDE macro. This
> > also reduces the number of used registers within that macro to one.
> >
> > Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> > ---
> >  arch/s390/kernel/entry.S | 8 +++-----
> >  1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/s390/kernel/entry.S b/arch/s390/kernel/entry.S
> > index a6b45eaa3450..e1664b45090f 100644
> > --- a/arch/s390/kernel/entry.S
> > +++ b/arch/s390/kernel/entry.S
> > @@ -169,11 +169,9 @@ _LPP_OFFSET      = __LC_LPP
> >        * @outside_label: jump here if @reg is outside of [@start..@end)
> >        */
> >       .macro OUTSIDE reg,start,end,outside_label
> > -     lgr     %r14,\reg
> > -     larl    %r13,\start
> > -     slgr    %r14,%r13
> > -     lghi    %r13,\end - \start
> > -     clgr    %r14,%r13
> > +     larl    %r14,\start
> > +     slgrk   %r14,\reg,%r14
> > +     clgfi   %r14,\end - \start
>
> Clever me.. slgrk was added with z196, and not z10.
> So dropping this patch.

How do the version numbers work for SystemZ? Is there a list/reference
you could link me to?  If it's too deep a rabbit hole, then nevermind,
but I would like to learn a little more about the architecture.
-- 
Thanks,
~Nick Desaulniers