Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220506022845.26750-1-puyou.lu@gmail.com>
In-Reply-To: <20220506022845.26750-1-puyou.lu@gmail.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 12 May 2022 22:49:30 +0200
Message-ID: <CACRpkdbVP4HL3UO9mfbRWCxfJ5e1v8PBm5sqfpCNXwcbaq=O5w@mail.gmail.com>
Subject: Re: [PATCH] lib/string_helpers: add allocated strarray to device resource.
To:     Puyou Lu <puyou.lu@gmail.com>, Tejun Heo <tj@kernel.org>
Cc:     Andy Shevchenko <andy@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Petr Mladek <pmladek@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Chris Down <chris@chrisdown.name>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, May 6, 2022 at 4:28 AM Puyou Lu <puyou.lu@gmail.com> wrote:

> This is a must to automatically release strarray when the device
> disappears.
>
> Signed-off-by: Puyou Lu <puyou.lu@gmail.com>

Looks correct to me.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

(But really Tejun is the one who knows how devres is supposed
to be used, added on To: line)

Yours,
Linus Walleij