Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220420203020.1412886-1-dlatypov@google.com> <CAFd5g454KM9-45NEjUN3JWTZmpajHY9to=CW7Ecg6z_5xorU+w@mail.gmail.com>
In-Reply-To: <CAFd5g454KM9-45NEjUN3JWTZmpajHY9to=CW7Ecg6z_5xorU+w@mail.gmail.com>
From:   Daniel Latypov <dlatypov@google.com>
Date:   Thu, 12 May 2022 07:28:09 -0700
Message-ID: <CAGS_qxro7Az_yJfjQYK0+0u2mu9E62xmRPD_8EKiq8ZNEd6qUg@mail.gmail.com>
Subject: Re: [PATCH] kunit: tool: stop using a shell to run kernel under QEMU
To:     Brendan Higgins <brendanhiggins@google.com>
Cc:     davidgow@google.com, linux-kernel@vger.kernel.org,
        kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
        skhan@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 11, 2022 at 4:22 PM Brendan Higgins
<brendanhiggins@google.com> wrote:
> > +                          extra_qemu_params=[])
> > diff --git a/tools/testing/kunit/qemu_configs/powerpc.py b/tools/testing/kunit/qemu_configs/powerpc.py
> > index 35e9de24f0db..6c901149726b 100644
> > --- a/tools/testing/kunit/qemu_configs/powerpc.py
> > +++ b/tools/testing/kunit/qemu_configs/powerpc.py
> > @@ -9,4 +9,4 @@ CONFIG_HVC_CONSOLE=y''',
> >                            qemu_arch='ppc64',
> >                            kernel_path='vmlinux',
> >                            kernel_command_line='console=ttyS0',
> > -                          extra_qemu_params=['-M pseries', '-cpu power8'])
> > +                          extra_qemu_params=['-M', ' pseries', '-cpu', 'power8'])
>
> This should be '-M', 'pseries', not '-M', ' pseries', (you left an
> extra space in.
>
> Note this actually breaks QEMU on my machine.

Thanks for catching this!

Ugh, I must have sent out a stale version of the .patch file.
My tree has the fix since I noticed it right as I was preparing to
send this out.

I have this locally:
-                          extra_qemu_params=['-M pseries', '-cpu power8'])
+                          extra_qemu_params=['-M', 'pseries', '-cpu',
'power8'])

Sent out as v2,
https://lore.kernel.org/linux-kselftest/20220512142555.3554396-1-dlatypov@google.com