Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1047387iob; Fri, 13 May 2022 21:01:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxp3ayj14PKlIxg2iWsjiRQJHXddSkDj+5iSubcnbuXQXbgz1JWdwcbPatyNErXRj/gKnQe X-Received: by 2002:a05:6000:1844:b0:20c:5672:9573 with SMTP id c4-20020a056000184400b0020c56729573mr6474671wri.538.1652500864103; Fri, 13 May 2022 21:01:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652500864; cv=none; d=google.com; s=arc-20160816; b=fJyqMF4l6qwSUZiSTt90IgLwWDsayHHKi+Hv89+EejMFk0cugY63s/X7eMNup4e0KS qqR80LfUaLfKOli2TwUaO38Lme7vNU+fq3aKjYP6T56p+6J9WPwTfu8QXcoqVMclSjFL NNBjmQeNNDhRmgs6xbEa8ztSdEcyIs/Phuc+1Y+3tTTLTm7zn4psUf18+0dpV4TwQA/f sJg82VaH3iE/x9xFOPifmHFkuEOE+vxTz/C351ZQcj3aFbaYY3mSsAsdByinHF60ztwi 68KfRnY6iuUTeOCCPY9hpbtpPi1SrfesM1t3SWRMyHlYsLgnFB/jlyYPNr8ohKMwv48B dJZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=lPghYXSX0kalQrPNTVzwLFmIBwTYBa11tH02mIA3nN8=; b=M2iS0pcLdqU/x+sM7eDWy2dpr5P4DnhtcCfoZw2I9xq4hpXYZCBqGFALJ+XnrQ71Hf AYfpU97ulwhzh2Bmc6dYOcIXdhm27AP/l1EZdCHAN/l/3CV7C/I/tCiMn2O71selRX8p ht/2Ifvi0Cl4zsOdM1JvV9tds1zf/rwAYRK72uhbeleJ1yE+krq1ndgj454dbj3NPef/ xeErRYOfJeDFR6YWWvfHSIJ+wHf5ebJJc4+/X7Unk/6EfCIvbbM50pAMj58uf+yCpmIo BamyvK6tEycDJG2TvnwCquOrIFjxGzwzPeuxdxoE7sYB2aSI6j/0OiO4tEjsdjfUV7BY 5O0w== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id v21-20020a05600c215500b00394356c3ce9si3705075wml.20.2022.05.13.21.01.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 21:01:04 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 382A64A5AA5; Fri, 13 May 2022 17:32:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358450AbiELVXY (ORCPT + 99 others); Thu, 12 May 2022 17:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349865AbiELVXV (ORCPT ); Thu, 12 May 2022 17:23:21 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 026FE24C752; Thu, 12 May 2022 14:23:19 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A511D106F; Thu, 12 May 2022 14:23:19 -0700 (PDT) Received: from lpieralisi (unknown [10.57.4.238]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 944173F66F; Thu, 12 May 2022 14:23:16 -0700 (PDT) Date: Thu, 12 May 2022 22:23:09 +0100 From: Lorenzo Pieralisi To: Bjorn Helgaas Cc: Parshuram Raju Thombare , tjoseph@cadence.com, bhelgaas@google.com, robh@kernel.org, kishon@ti.com, kw@linux.com, mparab@cadence.com, linux-pci@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: cadence: Clear FLR in device capabilities register Message-ID: References: <165228494389.11307.11313445181760109588.b4-ty@arm.com> <20220512190626.GA862290@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512190626.GA862290@bhelgaas> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2022 at 02:06:26PM -0500, Bjorn Helgaas wrote: > On Wed, May 11, 2022 at 05:02:35PM +0100, Lorenzo Pieralisi wrote: > > On Mon, 15 Nov 2021 23:39:16 -0800, Parshuram Raju Thombare wrote: > > > From: Parshuram Thombare > > > > > > Clear FLR (Function Level Reset) from device capabilities > > > registers for all physical functions. > > > > > > During FLR, the Margining Lane Status and Margining Lane Control > > > registers should not be reset, as per PCIe specification. > > > However, the controller incorrectly resets these registers upon FLR. > > > This causes PCISIG compliance FLR test to fail. Hence preventing > > > all functions from advertising FLR support if flag quirk_disable_flr > > > is set. > > > > > > [...] > > > > Applied to pci/cadence, thanks! > > > > [1/1] PCI: cadence: Clear FLR in device capabilities register > > https://git.kernel.org/lpieralisi/pci/c/d3dbd4d862 > > Obviously you've already seen the kbuild report: > https://lore.kernel.org/r/202205120700.X76G7aC2-lkp@intel.com > > but it looks like most of this patch got lost somehow :) Happy to fix > it up for you if you want! I have messed up the merge, now rebuilt my pci/cadence branch, it _should_ be fixed, apologies. Lorenzo