Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <39be28ea-1645-30c3-316e-87a43b8738a8@arm.com>
Date:   Fri, 13 May 2022 11:48:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] topology: Remove unused cpu_cluster_mask()
Content-Language: en-US
From:   Dietmar Eggemann <dietmar.eggemann@arm.com>
To:     Peter Zijlstra <peterz@infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Heiko Carstens <hca@linux.ibm.com>,
        Barry Song <21cnbao@gmail.com>
Cc:     linux-kernel@vger.kernel.org
References: <20220513093433.425163-1-dietmar.eggemann@arm.com>
In-Reply-To: <20220513093433.425163-1-dietmar.eggemann@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

- Barry Song <song.bao.hua@hisilicon.com> bounced
+ Barry Song <21cnbao@gmail.com>

On 13/05/2022 11:34, Dietmar Eggemann wrote:
> default_topology[] uses cpu_clustergroup_mask() for the CLS level
> (guarded by CONFIG_SCHED_CLUSTER) which is currently provided by x86
> (arch/x86/kernel/smpboot.c) and arm64 (drivers/base/arch_topology.c).
> 
> Fixes: 778c558f49a2c ("sched: Add cluster scheduler level in core and
> related Kconfig for ARM64")
> 
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> ---
>  include/linux/topology.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/include/linux/topology.h b/include/linux/topology.h
> index f19bc3626297..4564faafd0e1 100644
> --- a/include/linux/topology.h
> +++ b/include/linux/topology.h
> @@ -240,13 +240,6 @@ static inline const struct cpumask *cpu_smt_mask(int cpu)
>  }
>  #endif
>  
> -#if defined(CONFIG_SCHED_CLUSTER) && !defined(cpu_cluster_mask)
> -static inline const struct cpumask *cpu_cluster_mask(int cpu)
> -{
> -	return topology_cluster_cpumask(cpu);
> -}
> -#endif
> -
>  static inline const struct cpumask *cpu_cpu_mask(int cpu)
>  {
>  	return cpumask_of_node(cpu_to_node(cpu));