Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1048067iob; Fri, 13 May 2022 21:02:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkxsWK6ATCfPRwB7KkHeFque2295lU33wKRyefo1R7Odog1NwdSMpsW0ZGmER0p1hxKhJr X-Received: by 2002:a05:600c:5104:b0:394:7d22:aad8 with SMTP id o4-20020a05600c510400b003947d22aad8mr7237750wms.68.1652500947556; Fri, 13 May 2022 21:02:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652500947; cv=none; d=google.com; s=arc-20160816; b=butuxN3FIAFA7kxDyB9BmYdVVwmAnDNCLhE4+ibO3knPFvxLKodabWJE6kHFxaWPyA RdZ1D4c18244JjhEQyh4esuAGH/A63EMG8V3Hh2BKga+54TCKkp5TAujxuGmGzpNVRx+ g58sLMvCFLpEyZ+bzAbwxuTng3hI1TDcPdcJTIJym7e+hzlGZvw9sUVYU/097PKfZ8CO httiTIOfieo4V/7VDpcAQaoE62Yy00BLgMGCNukV26A5ug+rji81n49hgKSSerbS7u+N VnN1BMcGG27GwFpSnRZiVS/PxVjHHnHERvOqJTvCRY3CLvbfDebZiy2KhCE99GpY5KdX cjgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=Db25b490OZ5S6z126dqK5Fu9lI1imJGTZUzD11yBRow=; b=EcMNxUaXkEHcXcplKxO7Sd2KhFCFPwBDLu6lWKQYOtX48ZgvAp1eNBD7x0kyR0zGrq viPCfs06EmPkpKKjz4Inzok04E6SxwttMgKath38aW3w8bN9qUbzJCZCoShDnYwEdXZS UjkKrVeypeIIVHeUSFQ6Tp6vZjd0y0hqN4VoMBRHwcvD3Xofck4zZ8vazL+i2vQTvFj3 pq71n4lpUC0pCrMSHRDQiJxr3pRuM9CdWrHQXmML6z2M2FeJZjry6al7RYby5r0EKjWJ I5g1hu2EbrrWAR9/p2sAUrQHMu+L/QB3KzHVhWVEbroWsxbvxm1s6NI4ACZ5Mua0zWxg K2pA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id l1-20020a1c7901000000b00394573ec104si6725112wme.95.2022.05.13.21.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 21:02:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 897B3327AFA; Fri, 13 May 2022 17:33:37 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376597AbiEMC6E (ORCPT + 99 others); Thu, 12 May 2022 22:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376599AbiEMC6C (ORCPT ); Thu, 12 May 2022 22:58:02 -0400 Received: from mail.nfschina.com (unknown [IPv6:2400:dd01:100f:2:72e2:84ff:fe10:5f45]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B7025C84F for ; Thu, 12 May 2022 19:58:01 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 6C2B51E80C82; Fri, 13 May 2022 10:52:20 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PaVTrAFpiRlA; Fri, 13 May 2022 10:52:17 +0800 (CST) Received: from localhost.localdomain.localdomain (unknown [219.141.250.2]) (Authenticated sender: xupengfei@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id A27F71E80C80; Fri, 13 May 2022 10:52:17 +0800 (CST) From: XU pengfei To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kernel@nfschina.com, Xu Pengfei Subject: [PATCH] mm: Optimize the statement to make it clearer Date: Fri, 13 May 2022 10:57:54 +0800 Message-Id: <20220513025754.9230-1-xupengfei@nfschina.com> X-Mailer: git-send-email 2.18.2 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xu Pengfei Optimize the statement to make it clearer Signed-off-by: Xu Pengfei --- mm/filemap.c | 4 ++-- mm/mmap.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 9a1eef6c5d35..f6b2b915052a 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1374,9 +1374,9 @@ static inline int folio_wait_bit_common(struct folio *folio, int bit_nr, * waiter, but an exclusive one requires WQ_FLAG_DONE. */ if (behavior == EXCLUSIVE) - return wait->flags & WQ_FLAG_DONE ? 0 : -EINTR; + return (wait->flags & WQ_FLAG_DONE) ? 0 : -EINTR; - return wait->flags & WQ_FLAG_WOKEN ? 0 : -EINTR; + return (wait->flags & WQ_FLAG_WOKEN) ? 0 : -EINTR; } #ifdef CONFIG_MIGRATION diff --git a/mm/mmap.c b/mm/mmap.c index 3aa839f81e63..28196b93515a 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2975,9 +2975,9 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, goto out; } - prot |= vma->vm_flags & VM_READ ? PROT_READ : 0; - prot |= vma->vm_flags & VM_WRITE ? PROT_WRITE : 0; - prot |= vma->vm_flags & VM_EXEC ? PROT_EXEC : 0; + prot |= (vma->vm_flags & VM_READ) ? PROT_READ : 0; + prot |= (vma->vm_flags & VM_WRITE) ? PROT_WRITE : 0; + prot |= (vma->vm_flags & VM_EXEC) ? PROT_EXEC : 0; flags &= MAP_NONBLOCK; flags |= MAP_SHARED | MAP_FIXED | MAP_POPULATE; -- 2.18.2