Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1049875iob; Fri, 13 May 2022 21:06:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycez9bD4YOvdMqJOowT+EQXUkBM97ZQFgIQJVtY1H33uA4lZIFix9N+n8av8/H3MhFkifc X-Received: by 2002:a7b:c24d:0:b0:393:fac9:3015 with SMTP id b13-20020a7bc24d000000b00393fac93015mr7242854wmj.186.1652501186514; Fri, 13 May 2022 21:06:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652501186; cv=none; d=google.com; s=arc-20160816; b=aOUIZs5ADBLzqaHTSb4QZRvPetJcsDBVLRZjkJkJeFZWvwdtgHHW1Qx8KbOS1fJ0NW cGcssi1K6zaOQcoDqBF5u4t75Jea5y2Yack/Y7Vct1U0QpisKyYDFCeRS05vvFVmYMJF UjrwKm77WAhtNOBZnDrVRK6oWihDCuo+2KESwFRYIVYCXVbzEo31ODtHmppeD6NkGEnV eOjZ6wSgUg9Ojs6buUnz+4LbP6+MPPZfXC6NW56fsbQvf0iodaMQpFyXCsWV9jKsGAU0 LOtBGHnJhYf363pCvl7AbIUyI+4/iwfyWlX2JUPh6MDioyRwNxrKx0FHcMEFcV84ZfR6 Z6Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=wp2EX9vjKBERiNLVm2YqE4Qazcs+sBTSt8gG1hLKc48=; b=Dbk0UEnJX4UAy3L6yUmW9QnaqgWf06s8XOyWzaJlHzm1zDUfEsaLvd9HWpjE9cm+7l 43sFnSM/Lczx2297Q7zdF9xmDSPkuF1W+aZalhUZFKrkj8257QIWZyxiM2gYuLJGy0js HZSyxV6KaUNbu6B82obTR6V0a3UG170iaISA6ACwYgBPjIiXhjjq39le9dsUUVzIn7QT pAx3Ob4252M9/oSoLCmnqAi5CS7CII+D7Nzc4T56ty7gyYPeF+hfLe3SSoaeJkhlj9ax 52olepnUUYyrUUfs2LYSsmIvkd4doMPLGEPxxZTDvMzNE48MJRgTF+hZ4MpO1gUV2pQM 9TPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=0lEWBFfh; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j4-20020a05600c42c400b003944e1f8240si3651705wme.11.2022.05.13.21.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 21:06:26 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=0lEWBFfh; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 28551466F0F; Fri, 13 May 2022 17:38:02 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347725AbiEKXG3 (ORCPT + 99 others); Wed, 11 May 2022 19:06:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348992AbiEKXGS (ORCPT ); Wed, 11 May 2022 19:06:18 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11F7029C84 for ; Wed, 11 May 2022 16:06:17 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id 31so3025533pgp.8 for ; Wed, 11 May 2022 16:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=wp2EX9vjKBERiNLVm2YqE4Qazcs+sBTSt8gG1hLKc48=; b=0lEWBFfhsdG9IId5GVveiAnldtVBmoSpEs2i4HsAWqt/iB4StaKi6DfEsruofQfLWx uw7e1Ed0i836DvAtDxkr6W+u1IWP9ZhseUwzVXuybeGQYSFDJNv2tgH3y0P8/67FWFp2 AE9kjICIrnDNadxbQ0Lp/eE9JYnq6jncO37WK/GNovN/vfTq1esy1hVTDR61tXpJDylM 4AAnmAZIag4R7SrUZFtJP+zMFinnk9CGJP2y2wmA9GqSJYrHkRbGYXHVppR7NOAQW2Ix NtCtiqwIlMg6v6IOa74j1UPcctBQ+/gtJWUXar86UvPyQd5X+qoJz683pUA+eYOEbJcW P90w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=wp2EX9vjKBERiNLVm2YqE4Qazcs+sBTSt8gG1hLKc48=; b=QIUuvOt7LnoahJd5kwT6kRqPbjNJ3nd6Axw4UB8S1urr0BaStipXcbeQKJqtA99L5L 0rAkaY60+grEe/PSMXTvBrWsijd79qxOLLwIUhlfgYGDveAvD/NmWUGbEIp3AOOA4yX9 FOVqeQtUy4MxyIonRl24QfasIovdphgdVCCr5CKqGg6FkjOnPB8B0h4dI12Piu2G5XtT a3G8cX3qARWghoJhcc0GPKjUap8c4yw7y4LaCR609hq2g3l+Gu4sJnqDAJCLoZkyDSKu crcQDFL15cYRAIoAnOHPK7VptiYScNiZiwE5KO9Dfr4PjFAkR9I+Z5UtRlQvvEEgPeAy 3nuQ== X-Gm-Message-State: AOAM533nIV7kk4Q/wtMyAk2uKnmBaaQpdvaVY+OwIoVDBTab6AT9pC8j TDdPQ8NjjNA9MrPnzzwY+dr564bHRth57Q== X-Received: by 2002:a63:515:0:b0:3ab:84c3:3f37 with SMTP id 21-20020a630515000000b003ab84c33f37mr23152360pgf.110.1652310376457; Wed, 11 May 2022 16:06:16 -0700 (PDT) Received: from [127.0.1.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id q10-20020a170902f34a00b0015e8d4eb1d8sm2387443ple.34.2022.05.11.16.06.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 16:06:15 -0700 (PDT) From: Jens Axboe To: tj@kernel.org, zhouchengming@bytedance.com Cc: duanxiongchun@bytedance.com, songmuchun@bytedance.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20220510034757.21761-1-zhouchengming@bytedance.com> References: <20220510034757.21761-1-zhouchengming@bytedance.com> Subject: Re: [PATCH] blk-iocost: combine local_stat and desc_stat to stat Message-Id: <165231037549.15699.13051976092288865949.b4-ty@kernel.dk> Date: Wed, 11 May 2022 17:06:15 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 May 2022 11:47:57 +0800, Chengming Zhou wrote: > When we flush usage, wait, indebt stat in iocg_flush_stat(), we use > local_stat and desc_stat, which has no point since the leaf iocg > only has local_stat and the inner iocg only has desc_stat. Also > we don't need to flush percpu abs_vusage for these inner iocgs. > > This patch combine local_stat and desc_stat to stat, only flush > percpu abs_vusage for active leaf iocgs, then build inner walk > list to propagate. > > [...] Applied, thanks! [1/1] blk-iocost: combine local_stat and desc_stat to stat commit: 2a371f7d5fa575010b915e325c5d20b9ad0d5d5a Best regards, -- Jens Axboe