Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1050819iob; Fri, 13 May 2022 21:08:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx35jzCq0ZUw27+1xoMc/mQsiDq+kAgKcyxa+xWtTLehI6m/Dzhfg53DgjBJlD1KWkDx1+r X-Received: by 2002:a5d:5984:0:b0:20c:7de2:5416 with SMTP id n4-20020a5d5984000000b0020c7de25416mr6130092wri.30.1652501314131; Fri, 13 May 2022 21:08:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652501314; cv=none; d=google.com; s=arc-20160816; b=ICKWMYhN6q+v6MeH0C1mPPIJDDrxmLjn5G20WltmH97T1/GSlFloPjxGxQUaT5HQ/S 84l5tBDGw6okxTnpmyX1xbSgGrciOXghtm44xJa4gLobUvLIDvR+JodwTTG1U6Mqnuxy DidihrakXF1Tk/md8sO0fDwU0M+I8MGBYUn/FOIBpXy6lbC1olXQsxOj2ngS1xo1hLOA gmdSuf1Zf5ikpZ571GwD7oByJLztGvt7bJAXvrMngTDNXTVYIVw+5d83VmuNEA/EsX8f V8tA0fVf4S7u3VT7YUOf3A8oKKEUm+W8+kVkT1FOEi5/0J7uyM95MsoPMfWf8IejlMpd nITw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lC/lTbS1Cac4ah+UjmCrGwZl1dCdRXDsBkCYI6bUECo=; b=o5wYF5eSE+S1Ystyc1Fu+/evednAREzIuiKxSg8Jqd7GBnEZePONGK3cr+LD8hwQ2R EUVLbv4ThejdLvBLe1+91CfU2KC6grqWPlrVp/7wzRuCBh03tss75Hb+hBShpz7POrPl BujP5zwMPf0e1cTvDjWlyqgPybYchfu0DfgyAaDEE7RwM0d0MI3pfpHvEjUU3pxyw9Yd RVTJmSzvfntm7USqNYZYQsq/hs1z2t40NYiZ+E+9txWi1aTBUgch2koo+4thWSIXDW1d NSIjsuCaEgvkng4HGyp6wFP49e1x88SPHJehGoFR9dS0uZjTBXKSYZm2q1lxOSbaOwOc jtRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=eAquaO42; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id s14-20020a05600c384e00b00394157d0608si7143087wmr.199.2022.05.13.21.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 21:08:34 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=eAquaO42; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ED6484C9372; Fri, 13 May 2022 17:40:14 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351835AbiELJSq (ORCPT + 99 others); Thu, 12 May 2022 05:18:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242454AbiELJSo (ORCPT ); Thu, 12 May 2022 05:18:44 -0400 Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B78E22386F for ; Thu, 12 May 2022 02:18:41 -0700 (PDT) Received: from pps.filterd (m0148460.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24BMwVNH013938 for ; Thu, 12 May 2022 02:18:40 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=facebook; bh=lC/lTbS1Cac4ah+UjmCrGwZl1dCdRXDsBkCYI6bUECo=; b=eAquaO422+CLCZX27/dM09ACxwlYorP2Xjo8nnc8XGyUR/a4hdDko14XHId0OyEJTRN8 zIDeEuMAwjXDWtpaGv5PoyyZIjQ/UtepLIzwCqlwObc8OYrEgzr/mfs4OMSvVfUIwhbt KRulikZGIAsUNjdB2pqSoUO6bF3ZKQcuFcE= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3g04tb979b-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 12 May 2022 02:18:40 -0700 Received: from twshared4937.07.ash9.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:82::f) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 12 May 2022 02:18:38 -0700 Received: by devbig039.lla1.facebook.com (Postfix, from userid 572232) id 190198F02238; Thu, 12 May 2022 02:18:36 -0700 (PDT) From: Dylan Yudaken To: Jens Axboe , Pavel Begunkov CC: , , , Dylan Yudaken Subject: [PATCH 0/2] Fix poll bug Date: Thu, 12 May 2022 02:18:32 -0700 Message-ID: <20220512091834.728610-1-dylany@fb.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: USK0j05OpSsJMLoPJxkbNKS9qbhYgi0l X-Proofpoint-ORIG-GUID: USK0j05OpSsJMLoPJxkbNKS9qbhYgi0l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-12_02,2022-05-12_01,2022-02-23_01 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This fixes a bug in poll wakeups, where it would wake up unnecessarily. This is most obvious with sockets, where the socket will wake both readers and writers when new read data is available, even if th= e socket is still not writable. Patch 1 is a simple bug I noticed while debugging the poll problem Patch 2 is the poll fix Dylan Yudaken (2): io_uring: fix ordering of args in io_uring_queue_async_work io_uring: only wake when the correct events are set fs/io_uring.c | 5 +++-- include/trace/events/io_uring.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) base-commit: f569add47119fa910ed7711b26b8d38e21f7ea77 --=20 2.30.2