Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <b9ee331670fd40e69796dd428a844562842cdff3.camel@intel.com>
Subject: Re: [PATCH v3 2/2] hwmon: acpi_power_meter: convert to
 hwmon_device_register_with_info
From:   Zhang Rui <rui.zhang@intel.com>
To:     LABBE Corentin <clabbe@baylibre.com>,
        Guenter Roeck <linux@roeck-us.net>
Cc:     jdelvare@suse.com, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Fri, 13 May 2022 19:33:27 +0800
In-Reply-To: <Yn4QhhTI7t6Gi+fE@Red>
References: <20220509063010.3878134-1-clabbe@baylibre.com>
         <20220509063010.3878134-3-clabbe@baylibre.com>
         <e5f6c712-efed-2126-de2b-9a0d09150e7b@roeck-us.net> <Yn4QhhTI7t6Gi+fE@Red>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 2022-05-13 at 10:02 +0200, LABBE Corentin wrote:
> Le Wed, May 11, 2022 at 07:10:29PM -0700, Guenter Roeck a écrit :
> > Corentin,
> > 
> > On 5/8/22 23:30, Corentin Labbe wrote:
> > > Booting lead to a hwmon_device_register() is deprecated. Please
> > > convert the driver to use hwmon_device_register_with_info().
> > > So let's convert the driver to use
> > > hwmon_device_register_with_info().
> > > 
> > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > > ---
> > 
> > [ ... ]
> > 
> > > @@ -836,20 +740,20 @@ static void acpi_power_meter_notify(struct
> > > acpi_device *device, u32 event)
> > >   		if (res)
> > >   			break;
> > >   
> > > -		remove_attrs(resource);
> > > +		remove_domain_devices(resource);
> > >   		setup_attrs(resource);
> > 
> > Zhang Rui found an interesting problem with this code:
> > It needs a call to sysfs_update_groups(hwmon_dev->groups)
> > to update sysfs attribute visibility, probably between
> > remove_domain_devices() and setup_attrs().
> > 
> > >   		break;
> > >   	case METER_NOTIFY_TRIP:
> > > -		sysfs_notify(&device->dev.kobj, NULL,
> > > POWER_AVERAGE_NAME);
> > > +		hwmon_notify_event(&device->dev, hwmon_power,
> > > hwmon_power_average, 0);
> > 
> > ... which makes realize: The notification device should be the
> > hwmon device.
> > That would be resource->hwmon_dev, not the acpi device.
> > 
> 
> Hello
> 
> I will fix this, but do you have an example how to test thoses code
> path easily ?

No, I don't have one.

-rui