Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220317065024.2635069-1-maobibo@loongson.cn> <3a441789-b3e4-236e-2e44-e7a1c7258a94@redhat.com>
 <YmrB/7ehG2kj2RMn@xz-m1.local> <20220512173620.2f5175c7a321e6ccea6e58e9@linux-foundation.org>
 <8c1fc6d4-7d3a-85dd-ebd9-fc8e221f1878@loongson.cn> <69c4f018-2012-8af5-569b-289d2a8a80f5@loongson.cn>
 <20220512184908.0852e1efcb6fd78aea52b557@linux-foundation.org>
In-Reply-To: <20220512184908.0852e1efcb6fd78aea52b557@linux-foundation.org>
From:   Yang Shi <shy828301@gmail.com>
Date:   Thu, 12 May 2022 19:40:13 -0700
Message-ID: <CAHbLzkp-as+a9boJr5nU4TNzxhfn_zzEx+74-gv+WKGHyHg0PA@mail.gmail.com>
Subject: Re: [PATCH v3] mm/khugepaged: sched to numa node when collapse huge page
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     maobibo <maobibo@loongson.cn>, Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, May 12, 2022 at 6:49 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Fri, 13 May 2022 09:29:07 +0800 maobibo <maobibo@loongson.cn> wrote:
>
> >
> >
> > >> and/or changelogging.
> > > Sorry for the late response, the mail is filtered and I did not notice that. The result is not so obvious after bandwidth is improved between nodes, it is only about 1% improvement for specint2006 for 32 core on my box.
> > >
> > > Now I do not see negative effective about this patch unless user wants to keep some cores separated from khugepaged daemon process.
> >
> > Can we provide an extra parameter to let khugepaged daemon scheduling binded to node or freely? If can, I will provide updated patch.
>
> It has always surprised me that we have a single khugepaged thread.  If
> we had a thread per node, you'd be all fixed up, yes?

Actually I was thinking about this before, but I didn't see too much
benefit with this approach TBH. The khugepaged scans vmas and the
mapped pages may spread on all nodes. It is not like kswapd which
could scan the LRUs for the specific node.

>
> Ditto ksmd.
>