Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <bd3d4379-e4aa-79c7-85b8-cc930a04f267@fb.com>
Date:   Thu, 12 May 2022 08:16:21 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH 1/2] kernel/bpf: change "char *" string form to "char []"
Content-Language: en-US
To:     liqiong <liqiong@nfschina.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>
Cc:     netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, hukun@nfschina.com,
        qixu@nfschina.com, yuzhe@nfschina.com, renyu@nfschina.com
References: <20220512142814.26705-1-liqiong@nfschina.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <20220512142814.26705-1-liqiong@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjZKNVBLR0EvMTZMZC8zTFBDUE5ya2M2d2huL0pmbXA4a05veGxLa2pKRFBs?=
 =?utf-8?B?cnZRbHF0d3BuWEZHclBNc05TQ1hROFVhMjZ4WlBPYkFEeE1aN0NoR3Q0L1dC?=
 =?utf-8?B?cFRSNU14V2VJUDVvMlcvZURpdlZtd2V1OWRYK1JsVTU2b1RYemNWdVJUQk4z?=
 =?utf-8?B?QlJ6OGVhelh4N2VLbUxQSjFNaUFDUktoWFJVc3RFdWI5a042SStBTVpiazRk?=
 =?utf-8?B?bDdtMzZaajJmWDhQcHd5bExSYmdvRlRBZi8rWWJibFRQV0MwVXQ3aUUzMjJ0?=
 =?utf-8?B?THFra0JEa05FaTlGWTBnVTU1dVczRHFlcTN2dlRINTFHVHIvZUZGdTh4cDNz?=
 =?utf-8?B?QnkwVmFXS2R1NXJ2ZExBSW9VeUtHOG8xdk9CQ0dITWJOb3dPTjZsQ1QzNTIy?=
 =?utf-8?B?SmRuSDJ5OC9ZN1VWb1dzUnV1RUxHVjdSZlA4djl6S3BlL2pTcC9vQUxpU0Zv?=
 =?utf-8?B?Q1dBNjh5Vktod0dGSmlZa1BkRWRHczdCakdlL3ZKZ2RpZzliekZZeDdoY1Ax?=
 =?utf-8?B?bVB5RVY4VkZCVmxFaGtBUXVBcVpuWjJSd2FxRU15RjFyL2pmNXpRcmxlZlZr?=
 =?utf-8?B?VTlMbFpsTkxIMFlrN2VLM2UxRlpNbGUvWnRJelYwOUJtbGJQK1VEUEZENm9S?=
 =?utf-8?B?NHFKRU0wZmZ1bzJlQkx6dmc2ZCtOTGp2ZVViendkWTFJZ0EwWXdXcC9xSjd5?=
 =?utf-8?B?Z1ZqWW5telVERXh3eXJ5cVdCdUxJaVk3dUpSK1Q1SytIdTBwa2IwZUtpVmxN?=
 =?utf-8?B?eStHdlk0d0xtQ3ZadkRjNFNwQXlBZHkxa2lWTmdnK1JGcVZmWmZCWHVyTy85?=
 =?utf-8?B?L2lpUERUV2kzR29wSjBpaTh2VUdXb1NvK08wWjB6SVFia3VXYlBxeDMxV1Qw?=
 =?utf-8?B?OGtGcjJQK1hwWlRHckdtOFk0Z2J1cmFYOUE5RnFoNXpQekVQaS9qUk1hSnFt?=
 =?utf-8?B?NHJYTjN3WVYyQ0JzVXFWR1NuRVN0dC9rcktnWHZjQUwwbkt4eGM1Smh3aWMr?=
 =?utf-8?B?cEJ2V2RqbVI4SndyR3dNTVRoMC9lZjdEM1kydWVPQ2k2bEV1dldsZmZOWjc4?=
 =?utf-8?B?UlJEaXZ1QWFKWTVJdDRBTnY4bDhVQVlvY2pJaEhxUmJxRGk5R3ZyeEQyaWdO?=
 =?utf-8?B?YVdIbkJUdVNmSDJUMnpyN1ZJM3VZMUpLaDRuTnNFTlFmZ3BlUmxERG5FTnVk?=
 =?utf-8?B?TWZvNFc0bUNrZGZ0S1MrTTI1OHN4WUhhT011RFhIMzNnU3Fna3dSUVBrMTd1?=
 =?utf-8?B?TzNCQ3pvaWl2Q0JzWEhOMnpLSFQweXhiL0xoK2hYVWpIUlR1Qno1aDJyS2ZY?=
 =?utf-8?B?aTNINlhuMlVid0hkamhzR3JTNSsxYnpaK2tNc1dYdDVLTzBXYzVNa29XM0Fp?=
 =?utf-8?B?OEh0OXBiQXlNcWN4RVdDOXErdU8wak1xQjZ6TEo5eitxMng4ZWMzV2VHODNt?=
 =?utf-8?B?SnVSL0JESE13RDRUQ1ZoT1A3b2R0Y05HVWEvNTZrVjg1S3JvYWx0dFY0Z3RN?=
 =?utf-8?B?WUZmOXpyYk5UWXpkVmNOb1FadURrYkpPS2doQWFOck5oM2dTdENKNnNYTGU1?=
 =?utf-8?B?eGhFdWxVR1Z0cFkrby9kZGdCRFFzd1RudXQ1R2dGRDlUdEdiRnpIOElQa0Q0?=
 =?utf-8?B?SzNFanU0YUo4M1ArRGYxQXBzc2cyYkRNT2hHZXZNeEw1WFJLVjB2WlhWeXIz?=
 =?utf-8?B?eCtVQis5MGpPcmp1ekl5TEcwdkhHUHNUdnRvWEs3YUl0eC8xcjBWSmZVckR5?=
 =?utf-8?B?eXliMVJNdHhVWTZxRzZJOTYwYjhjaCtwdEdTNWx3VjVuSXVtK2N1QUpiVWph?=
 =?utf-8?B?b1VzMjhRVmdBc3IvMytoTWVJYjczaFNub1Zlc2xrT0JOWGtPREkxNkdKMmVV?=
 =?utf-8?B?bkk4TFc1Qk8ra0hPdmxPZkFhY29ZS0U3ejk3TUhPeHRCZEg0NThDOHIyZVUr?=
 =?utf-8?B?aEFIQmtDMUFVc1RNRWFSRlorTGpZYms4RENoK09QTm9aVjR5MVVSZG9aaUJY?=
 =?utf-8?B?bjIvK0ZwMG1Xdmc5dnhnT29YRTMrRE5wclFkdzhCWW5UR3dzOGxWN3ZzMkp0?=
 =?utf-8?B?NXYwN05vNi9KY0FGK3dpelFzNzlxVlZZeE51WVBuN2pGeVNqVkJYaGc1cDVj?=
 =?utf-8?B?em9vR0FGZ0pZVGxLOFVzdGtLNzZ5d2RveWJaL0xSVHkvUkR5Q2dzczdpNTRT?=
 =?utf-8?B?ZFhHcDRWcm9wTUdwd2xlWlNMTmRyZVAyMjF6RHVtblNLejBwMmJ0OVZyV1h3?=
 =?utf-8?B?NU1BRStXelFRNHp2NmQxRXBiVDNHOWhsKytTUjJiS0EvU3QySllSdzFDMlpE?=
 =?utf-8?B?ckV6UEl4cnZuK1dmWTFYUTlyb3h6MGZka2wyOXB1NGNzaVlSSWxKUWZWcmdu?=
 =?utf-8?Q?wO+9iLsv1zcP9UV0=3D?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 444ead33-ff97-4b84-66e2-08da342a612d
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 15:16:25.2013
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kiRHt5i4IfHCqmKCvVT3JtV6XHCsYMty4n4HkNyQCx3dop4EfeA/AdDupW7NShyA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3430
X-Proofpoint-GUID: -gXJYRRdqEAJ3gnR69m9QO4beZLtmMBz
X-Proofpoint-ORIG-GUID: -gXJYRRdqEAJ3gnR69m9QO4beZLtmMBz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-12_12,2022-05-12_01,2022-02-23_01
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/12/22 7:28 AM, liqiong wrote:
> The string form of "char []" declares a single variable. It is better
> than "char *" which creates two variables.

Could you explain in details about why it is better in generated codes?
It is not clear to me why your patch is better than the original code.

> 
> Signed-off-by: liqiong <liqiong@nfschina.com>
> ---
>   kernel/bpf/btf.c      | 4 ++--
>   kernel/bpf/verifier.c | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index 0918a39279f6..218a8ac73644 100644
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
> @@ -894,10 +894,10 @@ static const struct btf_type *btf_type_skip_qualifiers(const struct btf *btf,
>   static const char *btf_show_name(struct btf_show *show)
>   {
>   	/* BTF_MAX_ITER array suffixes "[]" */
> -	const char *array_suffixes = "[][][][][][][][][][]";
> +	static const char array_suffixes[] = "[][][][][][][][][][]";
>   	const char *array_suffix = &array_suffixes[strlen(array_suffixes)];
>   	/* BTF_MAX_ITER pointer suffixes "*" */
> -	const char *ptr_suffixes = "**********";
> +	static const char ptr_suffixes[] = "**********";
>   	const char *ptr_suffix = &ptr_suffixes[strlen(ptr_suffixes)];
>   	const char *name = NULL, *prefix = "", *parens = "";
>   	const struct btf_member *m = show->state.member;
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index d175b70067b3..78a090fcbc72 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -7346,7 +7346,7 @@ static int sanitize_err(struct bpf_verifier_env *env,
>   			const struct bpf_reg_state *off_reg,
>   			const struct bpf_reg_state *dst_reg)
>   {
> -	static const char *err = "pointer arithmetic with it prohibited for !root";
> +	static const char err[] = "pointer arithmetic with it prohibited for !root";
>   	const char *op = BPF_OP(insn->code) == BPF_ADD ? "add" : "sub";
>   	u32 dst = insn->dst_reg, src = insn->src_reg;
>