Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [PATCH bpf-next v3 0/2] Introduce access remote cpu elem support
 in BPF percpu map
To:     Feng zhou <zhoufeng.zf@bytedance.com>, ast@kernel.org,
        andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, rostedt@goodmis.org,
        mingo@redhat.com, jolsa@kernel.org, davemarchevsky@fb.com,
        joannekoong@fb.com, geliang.tang@suse.com
Cc:     netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com,
        songmuchun@bytedance.com, wangdongdong.6@bytedance.com,
        cong.wang@bytedance.com, zhouchengming@bytedance.com,
        yosryahmed@google.com
References: <20220513063952.41794-1-zhoufeng.zf@bytedance.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <d8447eee-31d0-f730-bc31-7e55c76135f4@iogearbox.net>
Date:   Fri, 13 May 2022 17:01:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20220513063952.41794-1-zhoufeng.zf@bytedance.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/13/22 8:39 AM, Feng zhou wrote:
[...]
> Changelog:
> ----------
> v2->v3: Addressed comments from Andrii Nakryiko.
> - use /* */ instead of //
> - use libbpf_num_possible_cpus() instead of sysconf(_SC_NPROCESSORS_ONLN)
> - use 8 bytes for value size
> - fix memory leak
> - use ASSERT_EQ instead of ASSERT_OK
> - add bpf_loop to fetch values on each possible CPU
> some details in here:
> https://lore.kernel.org/lkml/20220511093854.411-1-zhoufeng.zf@bytedance.com/T/

The v2 of your series is already in bpf-next tree, please just send a relative diff for
the selftest patch.

https://lore.kernel.org/lkml/165231901346.29050.11394051230756915389.git-patchwork-notify@kernel.org/

Thanks,
Daniel