Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [PATCH] ASoC: samsung: Fix refcount leak in aries_audio_probe
To:     Miaoqian Lin <linmq006@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
References: <20220512043828.496-1-linmq006@gmail.com>
From:   Jonathan Bakker <xc-racer2@live.ca>
Message-ID: <CY4PR04MB056741C407765D41970C8462CBCB9@CY4PR04MB0567.namprd04.prod.outlook.com>
Date:   Thu, 12 May 2022 07:06:50 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20220512043828.496-1-linmq006@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9d6b2806-70f9-4483-4ce9-08da3420aa38
X-MS-TrafficTypeDiagnostic: BYAPR04MB5367:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: o2b+V6HScMhd4tAfh12Evw3PpeUs36dkZgNkLn2/KdT+7eJtNTjwCeNwSrDPYmcwxtjs+JGC0q9GC4X/aq0BJ5G4PBnpefgRrJcMe0Jvtb/fCYjAgzPNUXv+XFSmbPLBbunMW1sBl/sIYs5fU6S6ThnDYo0+BCeDNtQGv5f2YbBhXfRoQBipgAbZ2go/WI/uHL21OcD4+U42KW0JB2/2CbkZpQ8Ylop/iEW0trjgWC4kDUN/vs2fo4jHhTNI0Oc2p0YZEo1EyIzQr10wj8erKGth9gRugsmEczsRPyb9B8k+MnXTMwNVfB/uUNhGOF1ua+xojZ+j2T3cX6JceDQuR52wp8QXwe3p/prdToeN2f9pwpPynQL8lnekER/T3SW0p1/VjGbKX0BZctAIi5Mjv8O6GZxvnQNnD47s9K/a1iqhh3L1nhhmJFVEUcYJC69Gz9E/5u36FF4K3cZNWImaq5RfHZG1J1jlCDlMbTcyJKtk2DTq3lLNaraju3g06iAlUx8PIsx89dAk+7L+x1ABFBaCx9DcwwsAbXKBmt2YngMN63Enx8Hq2VeRzVpdGwPukGVymNTxBNMKZnMLrr5TdQ==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGw4WVdLbE8wZkh5OWkyRHcvd2ZFUndTT1djVTl5OHh5TkRzQm5hbkdzTThS?=
 =?utf-8?B?TS8xRXY0WXBia3A5eFc1TGJZVVBlVFJpYXM2V3NXejF2L1VKMzd1K2l3UnFH?=
 =?utf-8?B?cU9PZWg5UGFTMUR5cnl2OFBYY0NkZ05uTWhKaWNrSGl5QTAyck56RmRKZG5t?=
 =?utf-8?B?K1gwTGFyTDdpZGltSVMrT3NGUFpFbk9iQnVzYlNrMFVBR2lMT3JiMkVwUExK?=
 =?utf-8?B?R2EwVmsvTERPcHplZjUrMS9BNkkyS1lpRFloRVZMM1hTWm8zc1NuSHJWY0Q0?=
 =?utf-8?B?SmhHQ0l3SkJsbGgrM3Z5VG5CekZHWEdoM3dqanV0Mng3TTQwalFHejRvWVBa?=
 =?utf-8?B?RlJ4YUhaakU1Mm1HWnNtdTNuemNDa1NkZVJFVGdXRWRZV2dWSFJKaG96QVJx?=
 =?utf-8?B?RTF1enVvU013aEhBZXJzVEFkTU1BbDJsVVJNaVJHb0UyLzVxbDdhNHRHQnE4?=
 =?utf-8?B?eStva3plS0ZiaU9ZandmN1kvMlVMWVdlemVybUplQUlIZzF6UCtpZG1relBz?=
 =?utf-8?B?K1RqOUhkdlhvOFpkMm5pVWo4d1NMb2REemUvUkRXV1d4b0x4Q3VuOVplOGRk?=
 =?utf-8?B?K3hNRjBlNlpXaTNsRWNrWnREeDQxTHlubEpVd01lRjNsSCtudG1Vc0pkTll2?=
 =?utf-8?B?SnY5QkpjQjdLa1AxRG1aSFp4T2xuRWZZenY1dkhMWDE2QUNhWHRHcGU3azF6?=
 =?utf-8?B?YjFKYTVVa0tWS3VOdVNUVjd5amE3YStLczROVUh6MTU0SHpleDI3bVhOUHpn?=
 =?utf-8?B?TDQzOTJKczdJdjFCdjlXYXY5cGpFZmFkczhLNmFtQ1F0aFQ5dE5SMUo3cDRM?=
 =?utf-8?B?c2FpUUVrMGQ4dlNPRG5XR2drNUEyZ2Fmb2xyQmR3c2c0OUpFa2VXRW1sTWxM?=
 =?utf-8?B?VzdGOWpJaTV1LzI2TjdyY1BCMkpiZkpRUlU0eG0vbnZoR1RFNlVSWlNIWDBz?=
 =?utf-8?B?cG9BckZMaE9WcFVwNVE3ejFaTldXUHpxbnNZeXlFaG1KU3RFb1RZbjIwaWVX?=
 =?utf-8?B?TURjZCtwUzRWZWgycGRtNUdzOVNRYm5qUDdzeTNXOFpRbUo5WjlSWXEvcll0?=
 =?utf-8?B?RFh6Nm5UcUdlbHRQNW9oU3FnQ09EaGVVR05EOFpNcVgyODdJL05EL2VjVmpv?=
 =?utf-8?B?bzZ6UWtQczV4QlRESjFRTGcwUmtqT01kWnZNWTlJdjZaYjhFbXN5bUhzdERV?=
 =?utf-8?B?VXIyTjJIeC9JN2FWSmV1SnFEME1sWCtiWVJCT3JLSXBqVnhGN2NZTGpJYmhk?=
 =?utf-8?B?NEkzQ1BOQnpKUEdqemFyMjBMbGRPQTNUeFJYa0l6Z2xOWmVFNDgzYmZhMHho?=
 =?utf-8?B?VXo2S0dTOHh5MytUVEQ3VWN0U0xIb1BONmg3dUxTRFU3MS8wNVpROHcxb29Y?=
 =?utf-8?B?OU1SUHE2NHk2T2hBYmtQeU9ISHUzaklnN05OZmtmY2FZVWRNWHZvZnQrQ3JS?=
 =?utf-8?B?ZnhWUkZzMXR5K2dvdFNKd2VQeDdBUnZRSUU0WXdSNmRjSGk2SmJVbmdZS2xw?=
 =?utf-8?B?WCtleEE0bmlaVzduL0hsdEZuaEdXTFhjVU9OQjRydHhmbzhqeTNnZGVpK3RW?=
 =?utf-8?B?cU1oNng1UWpJTGI3RHBlVmlhTzk3emlMMmZNUmw0L0oxdmdoSVloY1dKZ0tQ?=
 =?utf-8?B?TVJzcW5ERGdKdVM1YUhkcS83N04rZ0lrcEFsajQ3Qmxmamp1WUo3ODM4MjJD?=
 =?utf-8?B?Z0VtSktrSGh0bjBzWFpCUVNyVFRQVFd2Z0V5SmFzVDNSTktSemJLem5RVXJO?=
 =?utf-8?B?SDhDaTBtakM1REg5N3F3OTZ3WlNUWGw1dUM3aUJsVHZQcHlqRmFlSHJmRjht?=
 =?utf-8?B?b1ozSFIxN3FnY0MzYlVwdEwyVW1XaG43YjBKeDhMNnB3b0VpdjBxZ29iaGgw?=
 =?utf-8?B?YjN0NkU0RmZrZ3J2TmlobTRaanlVOFpicWlReUcreTZWZWpVSGZQYUQ4UE5R?=
 =?utf-8?B?MDdSdndDNkpacHJ0VkxGcjRvU2xJaGxiUittcVJnUjJqckFyWkQ5TkZLekhn?=
 =?utf-8?B?dWhqVjljU2lnPT0=?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-edb50.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d6b2806-70f9-4483-4ce9-08da3420aa38
X-MS-Exchange-CrossTenant-AuthSource: CY4PR04MB0567.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 14:06:53.2635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5367
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,FORGED_MUA_MOZILLA,
	FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	SPOOFED_FREEMAIL_NO_RDNS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Acked-by: Jonathan Bakker <xc-racer2@live.ca>

Thanks!
Jonathan

On 2022-05-11 9:38 p.m., Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> If extcon_find_edev_by_node() fails, it doesn't call of_node_put()
> Calling of_node_put() after extcon_find_edev_by_node() to fix this.
> 
> Fixes: 7a3a7671fa6c ("ASoC: samsung: Add driver for Aries boards")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  sound/soc/samsung/aries_wm8994.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8994.c
> index 5265e546b124..83acbe57b248 100644
> --- a/sound/soc/samsung/aries_wm8994.c
> +++ b/sound/soc/samsung/aries_wm8994.c
> @@ -585,10 +585,10 @@ static int aries_audio_probe(struct platform_device *pdev)
>  
>  	extcon_np = of_parse_phandle(np, "extcon", 0);
>  	priv->usb_extcon = extcon_find_edev_by_node(extcon_np);
> +	of_node_put(extcon_np);
>  	if (IS_ERR(priv->usb_extcon))
>  		return dev_err_probe(dev, PTR_ERR(priv->usb_extcon),
>  				     "Failed to get extcon device");
> -	of_node_put(extcon_np);
>  
>  	priv->adc = devm_iio_channel_get(dev, "headset-detect");
>  	if (IS_ERR(priv->adc))
>