Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 13 May 2022 17:18:11 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Minchan Kim <minchan@kernel.org>
Cc:     Mike Kravetz <mike.kravetz@oracle.com>,
        syzbot <syzbot+acf65ca584991f3cc447@syzkaller.appspotmail.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        llvm@lists.linux.dev, nathan@kernel.org, ndesaulniers@google.com,
        syzkaller-bugs@googlegroups.com, trix@redhat.com,
        Matthew Wilcox <willy@infradead.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        John Hubbard <jhubbard@nvidia.com>,
        David Hildenbrand <david@redhat.com>
Subject: Re: [syzbot] WARNING in follow_hugetlb_page
Message-Id: <20220513171811.3604fb2da04615100c5ed160@linux-foundation.org>
In-Reply-To: <Yn7vnpXwX50J3K+7@google.com>
References: <000000000000ef451a05dee0f2b1@google.com>
        <00000000000077377c05dee75f63@google.com>
        <20220513102617.c464c4f566052838e911a3ec@linux-foundation.org>
        <75f09063-d184-7d44-17a1-ed04be5eb953@oracle.com>
        <a7fd0c3f-921e-19b3-2f67-a231dede28f9@oracle.com>
        <20220513161910.d1b73583cdb2e33562aa86e5@linux-foundation.org>
        <Yn7vnpXwX50J3K+7@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 13 May 2022 16:54:06 -0700 Minchan Kim <minchan@kernel.org> wrote:

> > > >> has been there over a month so I guess it's something else.  Does
> > > >> someone have the time to bisect?
> > > > 
> > > > I can recreate in my 'easy to debug' environment, so I can bisect in
> > > > parallel with other things I need to do today.
> > > > 
> > > 
> > > I isolated this to Minchan Kim's "mm: fix is_pinnable_page against on cma
> > > page".  Yes, the fat finger fix is in next-20220513.
> > > 
> > > I don't have time to analyze right now, but can confirm that in the
> > > reproducer is_pinnable_page is returning false after this change when it
> > > previously returned true.
> > 
> > OK, thanks, I dropped mm-fix-is_pinnable_page-against-on-cma-page.patch
> 
> Seems like bug of the patch v5 due to change of this
> 
>     if (mt & (MIGRATE_CMA | MIGRATE_ISOLATE))
> 
> The migration type is not bit type so it shold be 
> 
> if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE)
> 

argh, I meant to check that change but the grey cell died.

I'll bring it back, with

--- a/include/linux/mm.h~mm-fix-is_pinnable_page-against-on-cma-page-fix
+++ a/include/linux/mm.h
@@ -1635,7 +1635,7 @@ static inline bool is_pinnable_page(stru
 	int __mt = get_pageblock_migratetype(page);
 	int mt = __READ_ONCE(__mt);
 
-	if (mt & (MIGRATE_CMA | MIGRATE_ISOLATE))
+	if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE)
 		return false;
 #endif
 
_