Received: by 2002:a19:651b:0:0:0:0:0 with SMTP id z27csp839720lfb; Fri, 13 May 2022 21:26:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJrDMGpCIOiTXaIpLJIf/yP1LWhFZGzoXSSD1uGbl9Dl3SZbTZRrmzK9JCiZBaRzXjq4uc X-Received: by 2002:a05:6000:12ca:b0:20a:dba5:d5f3 with SMTP id l10-20020a05600012ca00b0020adba5d5f3mr6033270wrx.149.1652502372487; Fri, 13 May 2022 21:26:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652502372; cv=none; d=google.com; s=arc-20160816; b=rPmscCpuZ+UUu0TWD8L/xNEXfcWZlDQsvc8jOOBjoMheNX8FOOfEh6jkto4yYnNnse 9af2rE74WdNtHFZ2/b125mT+qvRAAp8wTql85BWDdNO3pO49/OAbGJoKcBx6smhWK2M9 Y3UJ/0PIXdfiqo1XGiEHdVxjiDyeaw8v0TPR2rs+28C+yekThSAsjJaw4EKC2Cwal7kN 1u2nmqL2YRUIUuZnOMMcga8HlCbhS8mBgryHzgBp5WW0AQNM7ITxaK17U1CJ4reuTLcf 2PE6vhF2sL5MH7sVTGtqlJGaqCyUbuFz7iwIZVDuXWhMVlILXaGHI2KAjwzXiFQoOk4Z 8jaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=aVeKEsQGDCoBxm0SFLizgiYh+MT/NsWJtXVOA4+fv30=; b=TGZRnmDyDnXHP/G7x0t5v+W/Ecgz4LA+iWsaayEyVoF40LIGr3rbsLHdgIuKtVm6/g aOQVEqdfl4GKRSvnMuBSa/g8DYYrJwlRiCgNhN8Q4C0fhXAQqntcYtsLkYq2uyOiEs5P We+DSepbm//d6/UZ37Rgf+yWxO1GfFhYaGmYm5bXzl4F5HcVV9qbGoZrluXHrkrwYmjK IRL1YoXQ5shedPPuwSBzqSVmacjHoLA2ohNLY+dMjs2aFGbPFZqqAsSUlUFr7RFd3nbq h+fn0tabrKERqOiEobIxBd9z1e3IWn/70AaRjY2KnoVi5vJflkb3PdKY18W4zEYn4Ffn s4qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I2XyV2+s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id k6-20020a5d5246000000b0020c76b6bf52si3964050wrc.164.2022.05.13.21.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 21:26:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I2XyV2+s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A56AD34AC8E; Fri, 13 May 2022 19:48:15 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229837AbiENCr7 (ORCPT + 99 others); Fri, 13 May 2022 22:47:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbiENCr5 (ORCPT ); Fri, 13 May 2022 22:47:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 139584F6133; Fri, 13 May 2022 17:49:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6728AB8324C; Sat, 14 May 2022 00:20:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 258A4C34100; Sat, 14 May 2022 00:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652487612; bh=VbH6Eye7rDprrBdwdIeqL7tRQ78t85laQ8YSPwhSV1g=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=I2XyV2+sHI8TA9wcJNxT+5veFxwxzCz6kr4ib/sqAPVTZSnlQJr7LoIULCQwDHawP nZFFYmtBjh6jhN8d8a3gQFpEe0mu1WKaOLZjvCPsnt60zGNwt62C4yp5Yyb8Kpk8IR tqvMOYUH6WNq1Eb97oaJ1SAGayzg9Sw2wRGVdaS6zLTU9y4wrpwXHuU5IR3NGF8SG5 ScflNvtOuq3Rw7o0q/Flwqf1kaxoPknVMMI+AFKOmT4u2qIdhNZXU6pL8kLLdZPDSb hWufMt9mInN3DMIbNS5+uzge+JlZOAifYLgZSP2NQHBMU/FpGJkMdu1HbI0Z5My0Q3 NEl7oBPrCNWqQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 0A830F03934; Sat, 14 May 2022 00:20:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] net: macb: Increment rx bd head after allocating skb and buffer From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165248761203.19970.11604393560078071280.git-patchwork-notify@kernel.org> Date: Sat, 14 May 2022 00:20:12 +0000 References: <20220512171900.32593-1-harini.katakam@xilinx.com> In-Reply-To: <20220512171900.32593-1-harini.katakam@xilinx.com> To: Harini Katakam Cc: nicolas.ferre@microchip.com, davem@davemloft.net, claudiu.beznea@microchip.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michal.simek@xilinx.com, harinikatakamlinux@gmail.com, radhey.shyam.pandey@xilinx.com X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Thu, 12 May 2022 22:49:00 +0530 you wrote: > In gem_rx_refill rx_prepared_head is incremented at the beginning of > the while loop preparing the skb and data buffers. If the skb or data > buffer allocation fails, this BD will be unusable BDs until the head > loops back to the same BD (and obviously buffer allocation succeeds). > In the unlikely event that there's a string of allocation failures, > there will be an equal number of unusable BDs and an inconsistent RX > BD chain. Hence increment the head at the end of the while loop to be > clean. > > [...] Here is the summary with links: - [v2] net: macb: Increment rx bd head after allocating skb and buffer https://git.kernel.org/netdev/net/c/9500acc631db You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html