Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <7e12e950-fece-845f-6784-d3e59480f810@acm.org>
Date:   Fri, 13 May 2022 19:41:35 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH linux-next] scsi: target: cxgbit: replace ternary operator
 with min()
Content-Language: en-US
To:     Guo Zhengkui <guozhengkui@vivo.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Mike Christie <michael.christie@oracle.com>,
        Varun Prakash <varun@chelsio.com>,
        "open list:SCSI TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
        "open list:SCSI TARGET SUBSYSTEM" <target-devel@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Cc:     zhengkui_guo@outlook.com
References: <20220512133754.40849-1-guozhengkui@vivo.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20220512133754.40849-1-guozhengkui@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/12/22 06:37, Guo Zhengkui wrote:
> diff --git a/drivers/target/iscsi/cxgbit/cxgbit_cm.c b/drivers/target/iscsi/cxgbit/cxgbit_cm.c
> index 3336d2b78bf7..6d9a13da6cb7 100644
> --- a/drivers/target/iscsi/cxgbit/cxgbit_cm.c
> +++ b/drivers/target/iscsi/cxgbit/cxgbit_cm.c
> @@ -1008,7 +1008,7 @@ int cxgbit_ofld_send(struct cxgbit_device *cdev, struct sk_buff *skb)
>   	ret = cxgb4_ofld_send(cdev->lldi.ports[0], skb);
>   	if (ret < 0)
>   		kfree_skb(skb);
> -	return ret < 0 ? ret : 0;
> +	return min(ret, 0);
>   }
>   
>   static void cxgbit_release_tid(struct cxgbit_device *cdev, u32 tid)
> @@ -1039,7 +1039,7 @@ cxgbit_l2t_send(struct cxgbit_device *cdev, struct sk_buff *skb,
>   	ret = cxgb4_l2t_send(cdev->lldi.ports[0], skb, l2e);
>   	if (ret < 0)
>   		kfree_skb(skb);
> -	return ret < 0 ? ret : 0;
> +	return min(ret, 0);
>   }
>   
>   static void cxgbit_send_rx_credits(struct cxgbit_sock *csk, struct sk_buff *skb)

I prefer to keep the existing code since "return min(ret, 0)" is not how 
humans write kernel code.

Thanks,

Bart.