Date: Sun, 13 May 2007 11:59:47 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Lukas Hejtmanek <xhejtman@ics.muni.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Workaround for a PCI restoring bug
Message-Id: <20070513115947.105fb1ba.akpm@linux-foundation.org>
In-Reply-To: <20070513122113.GA3632@ics.muni.cz>
References: <20070512201237.GB3569@ics.muni.cz>
	<20070512234743.0a8a915f.akpm@linux-foundation.org>
	<20070513085718.GD3580@ics.muni.cz>
	<20070513021119.c4f14bd3.akpm@linux-foundation.org>
	<20070513122113.GA3632@ics.muni.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1548
Lines: 39

On Sun, 13 May 2007 14:21:14 +0200 Lukas Hejtmanek <xhejtman@ics.muni.cz> wrote:

> On Sun, May 13, 2007 at 02:11:19AM -0700, Andrew Morton wrote:
> > > I've also noticed that someone pointed out that for some reason, PCI config
> > > space is saved twice, the first is OK, the second saves already disabled
> > > devices. Unfortunately, I'm unable to find this discussion in LKM.
> > 
> > Yeah, that sounds risky.
> > 
> > Can you put a dump_stack() call into the PCI saving function?  That way
> > we'll see what the two call paths are.
> 
> I did it, but it seems to be OK. PCI saves only once each device. So the issue
> was not related to this.
> 
> So what should I try next?
> 

So.... we don't know 0xffffffff's are getting into dev->saved_config_space[]?


Possibly we're saving the device's state when it is already partway or
fully through the suspend process, dunno.

What if you were to put code into pci_save_state() to detect when it reads
an oxffffffff?  Do a dump_stack() and print pci_dev->current_state and
->enable_cnt and various other things in there?


Or maybe we've done something in the wrong order which has affected our
ability to access this device.  Print the order in which devices are
getting suspended, let's see if we're taking down the bridge(s) in the
correct order.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/