Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 14 May 2022 16:49:33 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Alexandru Ardelean <ardeleanalex@gmail.com>
Cc:     LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>,
        Lars-Peter Clausen <lars@metafoo.de>,
        mchehab+huawei@kernel.org, linux-iio <linux-iio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mike Looijmans <mike.looijmans@topic.nl>,
        devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH V2 6/6] dt-bindings: iio: accel: Add bmi085 and bmi090l
 bindings
Message-ID: <20220514164933.4edbc459@jic23-huawei>
In-Reply-To: <CA+U=DspAtKrDdgrzAyELDULQVjj6eFgMhsZjFCOXXYrxFAW6YQ@mail.gmail.com>
References: <20220510141753.3878390-1-Qing-wu.Li@leica-geosystems.com.cn>
        <20220510141753.3878390-7-Qing-wu.Li@leica-geosystems.com.cn>
        <CA+U=DspAtKrDdgrzAyELDULQVjj6eFgMhsZjFCOXXYrxFAW6YQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 12 May 2022 10:32:55 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:

> On Tue, May 10, 2022 at 5:18 PM LI Qingwu
> <Qing-wu.Li@leica-geosystems.com.cn> wrote:
> >
> > Adds the device-tree bindings for the Bosch
> > BMI085 and BMI090L IMU, the accelerometer part.
> >  
> 
> I think some datasheet links could be added to this file for the new devices.
> 
> The BMI088 has a link to its datasheet.
> 
> > Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> > ---
> >  Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > index 911a1ae9c83f..4290f5f88a8f 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > @@ -18,6 +18,8 @@ properties:
> >    compatible:
> >      enum:
> >        - bosch,bmi088-accel
> > +      - bosch,bmi085-accel
> > +      - bosch,bmi090l-accel

Alphabetical /numeric order preferred. Also, fun question of compatible
fallbacks as per the previous email.  Other than ID you state the bmi080l
has same scales etc as the bmi088 so that one should definitely have
a fallback to bmi088.

The bmi085 is a little less obvious.  We can detect the difference by
the chip id though so a fallback compatible probably makes sense for
that one as well.  DT maintainers - I'll go with whatever you recommend
on that front.

Also, driver doesn't currently have an of_id_table so relies on the fallback
handling of the spi core. Please add an explicit table to the driver.

Thanks,

Jonathan

> >
> >    reg:
> >      maxItems: 1
> > --
> > 2.25.1
> >