Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220511090456.3428850-1-zhengbin13@huawei.com>
In-Reply-To: <20220511090456.3428850-1-zhengbin13@huawei.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Sat, 14 May 2022 14:39:33 +0200
Message-ID: <CAMRc=MdpA+UgsDsWp7i_jKhN2TL89ZWBu2_NYdi24wo09yi1Sw@mail.gmail.com>
Subject: Re: [PATCH -next] ARM: davinci: da850-evm: add missing
 platform_device_unregister in da850_lcd_hw_init
To:     Zheng Bin <zhengbin13@huawei.com>
Cc:     Sekhar Nori <nsekhar@ti.com>, Russell King <linux@armlinux.org.uk>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        gaochao49@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 11, 2022 at 10:51 AM Zheng Bin <zhengbin13@huawei.com> wrote:
>
> da850_lcd_hw_init misses a call platform_device_unregister in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
>  arch/arm/mach-davinci/board-da850-evm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
> index efc26b472ef8..7b2a1a37e5c0 100644
> --- a/arch/arm/mach-davinci/board-da850-evm.c
> +++ b/arch/arm/mach-davinci/board-da850-evm.c
> @@ -873,8 +873,10 @@ static int da850_lcd_hw_init(void)
>                 return PTR_ERR(backlight);
>
>         status = platform_device_register(&da850_lcd_supply_device);
> -       if (status)
> +       if (status) {
> +               platform_device_unregister(backlight);
>                 return status;
> +       }
>
>         return 0;
>  }
> --
> 2.31.1
>

Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl>