Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2021409iob; Sun, 15 May 2022 05:46:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxd0pyS3vII9JQEO409aWHuResWjAt+pQfUQxIv3IxL+uCiKAqHrr3/7EmwHz/BfoqwvtHB X-Received: by 2002:a17:906:2989:b0:6f3:a215:8426 with SMTP id x9-20020a170906298900b006f3a2158426mr11666758eje.725.1652618796086; Sun, 15 May 2022 05:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652618796; cv=none; d=google.com; s=arc-20160816; b=tL1o4T6uIkSMWpMcgYlmSUoj4IvKzrXcHHKnuIKUAiEdWNk7SbfBDkXKvKD3IuJ4NC 9X1IiByt5l49LNCVRfuS+60BFOIHtUXrfxQZ53rXUXDKHI20T3G1rk0RqO+4UVQXo8rf MVHMKnzABcu6rkWLgWezmyIUJvTrO8pWmBKeDTG/ubrlkmvSxURsYNC1w0ZYknADGtIk nyyZJnIK3hnDh3uaggDC7gW4RPYedMWR/rPP/sy/I/hrlO6bHHR/6Wi6+MBe3pPyUsiL yvt9aMRo+KLjPFzGUiJb/kRIUoavjGN4rJmOJnYpi3wlgE6gqCTtHoFEFW4iK3+QrI+l W1mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=KLDGJ+XUhBPXixy1Zg7PlcK9TVzkkUVTXCexNedRPdw=; b=q0l3pq38rJXFuI7l97l98BOYoSbHcG3z7zOY8zc5e504of3o3Cp7Mbsi24adcJ3VQx 2tZDkJ0TrDaB2USSF+us3FYSuJT+qUn8ViKGClMC1NzqMpqpc3u7/k0S2WnZmwGvZIOg 4NJdcaQyZbFA3dpBcS4lhC1jTQvtwL0GX6jhICNgMRat7Gqpl0euOIkVXKZh4VpBafx4 /RXd7APEgFDeDlnV3ng1zwmctgxXoxyWDJc9H8m9lXQr58RVu9OTH0kKsJRF3dRAsRHT OAX7+le4PAwQ4oVFSD2PUbDKnxdcWKjY1jYvmDb6z2QnhFvEHKfIjycOj/0lveEAJaiE 2irA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sbzioa5h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e6-20020a056402190600b00427ad731210si8315010edz.290.2022.05.15.05.46.10; Sun, 15 May 2022 05:46:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sbzioa5h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233319AbiENObh (ORCPT + 99 others); Sat, 14 May 2022 10:31:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232498AbiENObg (ORCPT ); Sat, 14 May 2022 10:31:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0179719014; Sat, 14 May 2022 07:31:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A335FB808D2; Sat, 14 May 2022 14:31:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9849FC340EE; Sat, 14 May 2022 14:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652538692; bh=KLDGJ+XUhBPXixy1Zg7PlcK9TVzkkUVTXCexNedRPdw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sbzioa5hOPlt9gboLS22zB5omo907tZtRH6IInLQ1CrfnwkK2NfOpZOJ1gEhi6Fmz wJ889Mle+VD6igOIw2INvZpDAuHTEx9HKZdwk3ubcTh4BQLZq4OK+6Bv+FOUWtkAce OP2GafNWUcvJeVMModmVglfT7SsB1J/BwC2DR5vUxADkW4qDlDdXQseDx66NhqUybk sjRD7kqKoUxNbKI5Ll1jiuVmWjkX9OaAGWSdbfhlkOD5TYPKXSSJ6OzxdOP2VOjQvp q51Wk+roELj09l29LBs1MdWGOaWS9AHtfMKaEaj9GLEWTXV5dUnvfPmumqCI7qHjh4 KpqruflA0jFgQ== Date: Sat, 14 May 2022 16:31:28 +0200 From: Wolfram Sang To: Quan Nguyen Cc: Corey Minyard , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Brendan Higgins , Benjamin Herrenschmidt , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" Subject: Re: [PATCH v7 3/3] i2c: aspeed: Assert NAK when slave is busy Message-ID: Mail-Followup-To: Wolfram Sang , Quan Nguyen , Corey Minyard , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Brendan Higgins , Benjamin Herrenschmidt , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" References: <20220422040803.2524940-1-quan@os.amperecomputing.com> <20220422040803.2524940-4-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/Jcb04ZVbWq3W2FY" Content-Disposition: inline In-Reply-To: <20220422040803.2524940-4-quan@os.amperecomputing.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/Jcb04ZVbWq3W2FY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 22, 2022 at 11:08:03AM +0700, Quan Nguyen wrote: > When processing I2C_SLAVE_WRITE_REQUESTED event, if slave returns > -EBUSY, i2c controller should issue RxCmdLast command to assert NAK > on the bus. That should be I2C_SLAVE_WRITE_RECEIVED and it should be NAKed on all errnos. Have you tested it? --/Jcb04ZVbWq3W2FY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmJ/vT8ACgkQFA3kzBSg KbYtRxAAnwySTv44cgVvd57fhPZJ4l4tcBSK97yFdMtZ2UNRFfyFclUiH9skwsuO KOmHb1UatGOYAoMyxrPIkiOXkeIeL/vlIkgI0d4CjL0pWKNrNIqqSncRdnpsDO8u 4efBzlk9D2iNkA7y9OAuBxHwONT41qUX5fgOymGpF56b/X/4sHJjV20pcFewfb/0 3ykk9Y5QJDq+h5va+IXp0O2ED6u8nZxn+/RAy+JiJFX+ynFzf6MYMrsFEJ4uVB20 T8/0HKkL0I+TMOMwdu62Blkbo324e3mxvilD6D9buGzpclYxAQb5pw1TRKxkiBxu hGrjg3J66VECV7Segwb9gO/JoV1u+jinAXD2xWmQoR29jfb4n9IW/WGy1/meEe43 GJ9tVo9DGxPUT+nwnpV14oZFQxmrRdZaHzwf4cFpnuVbZZspgSBMM2mjJzpHv3Qq 9pABXmjzY8LdzVQAAnCpk2062gS2r0hnVnCs7WdgAsAHqzZ/ioYBFyD7Qo5RChe5 ilimRgUz2brUuVf7K9VxR3JBCBMJ+C7O5Hc1Ii33pIw09mzI1395q6FbzfPz8oWJ yXiOivGAf0xBdw8N3J2rQ6e/7lEBWH88KO/bttKAr1CJChuotX3enJH5gvDakGNb 7gPDMh7sDqcTC5a6vBSuhWF76dZlfgYFA6NYuCn2iNTL8LyBATs= =xB1Q -----END PGP SIGNATURE----- --/Jcb04ZVbWq3W2FY--