Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8c6b0c27-26e3-6668-06b2-57dd27f77496@xen0n.name>
Date:   Sun, 15 May 2022 17:20:20 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.0a1
Subject: Re: [PATCH V10 11/22] LoongArch: Add process management
Content-Language: en-US
To:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc:     linux-arch@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Huacai Chen <chenhuacai@gmail.com>,
        Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>
References: <20220514080402.2650181-1-chenhuacai@loongson.cn>
 <20220514080402.2650181-12-chenhuacai@loongson.cn>
From:   WANG Xuerui <kernel@xen0n.name>
In-Reply-To: <20220514080402.2650181-12-chenhuacai@loongson.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/14/22 16:03, Huacai Chen wrote:
> Add process management support for LoongArch, including: thread info
> definition, context switch and process tracing.
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
>   arch/loongarch/include/asm/fpu.h         | 129 +++++++
>   arch/loongarch/include/asm/idle.h        |   9 +
>   arch/loongarch/include/asm/mmu.h         |  16 +
>   arch/loongarch/include/asm/mmu_context.h | 152 ++++++++
>   arch/loongarch/include/asm/processor.h   | 209 +++++++++++
>   arch/loongarch/include/asm/ptrace.h      | 152 ++++++++
>   arch/loongarch/include/asm/switch_to.h   |  37 ++
>   arch/loongarch/include/asm/thread_info.h | 106 ++++++
>   arch/loongarch/include/uapi/asm/ptrace.h |  52 +++
>   arch/loongarch/kernel/fpu.S              | 264 ++++++++++++++
>   arch/loongarch/kernel/idle.c             |  16 +
>   arch/loongarch/kernel/process.c          | 260 ++++++++++++++
>   arch/loongarch/kernel/ptrace.c           | 431 +++++++++++++++++++++++
>   arch/loongarch/kernel/switch.S           |  35 ++
>   14 files changed, 1868 insertions(+)
>   create mode 100644 arch/loongarch/include/asm/fpu.h
>   create mode 100644 arch/loongarch/include/asm/idle.h
>   create mode 100644 arch/loongarch/include/asm/mmu.h
>   create mode 100644 arch/loongarch/include/asm/mmu_context.h
>   create mode 100644 arch/loongarch/include/asm/processor.h
>   create mode 100644 arch/loongarch/include/asm/ptrace.h
>   create mode 100644 arch/loongarch/include/asm/switch_to.h
>   create mode 100644 arch/loongarch/include/asm/thread_info.h
>   create mode 100644 arch/loongarch/include/uapi/asm/ptrace.h
>   create mode 100644 arch/loongarch/kernel/fpu.S
>   create mode 100644 arch/loongarch/kernel/idle.c
>   create mode 100644 arch/loongarch/kernel/process.c
>   create mode 100644 arch/loongarch/kernel/ptrace.c
>   create mode 100644 arch/loongarch/kernel/switch.S

The context handling code already saw use in released version of strace 
[1] [2], so it appears appropriate to consider the user-space additions 
to be in a reasonably good shape already.

Reviewed-by: WANG Xuerui <git@xen0n.name>

[1]: https://github.com/strace/strace/pull/205
[2]: https://github.com/strace/strace/pull/207