Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8bf80bfd-7d49-a82e-22af-6b67ac80d0fd@xen0n.name>
Date:   Sun, 15 May 2022 21:35:43 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.0a1
Subject: Re: [PATCH V10 18/22] LoongArch: Add PCI controller support
Content-Language: en-US
To:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc:     linux-arch@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Huacai Chen <chenhuacai@gmail.com>,
        Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Jianmin Lv <lvjianmin@loongson.cn>
References: <20220514080402.2650181-1-chenhuacai@loongson.cn>
 <20220514080402.2650181-19-chenhuacai@loongson.cn>
From:   WANG Xuerui <kernel@xen0n.name>
In-Reply-To: <20220514080402.2650181-19-chenhuacai@loongson.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 5/14/22 16:03, Huacai Chen wrote:
> Loongson64 based systems are PC-like systems which use PCI/PCIe as its
> I/O bus, This patch adds the PCI host controller support for LoongArch.
>
> Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
>   arch/loongarch/include/asm/dma.h |  13 +++
>   arch/loongarch/include/asm/pci.h |  40 +++++++
>   arch/loongarch/pci/acpi.c        | 172 +++++++++++++++++++++++++++++++
>   arch/loongarch/pci/pci.c         |  98 ++++++++++++++++++
>   4 files changed, 323 insertions(+)
>   create mode 100644 arch/loongarch/include/asm/dma.h
>   create mode 100644 arch/loongarch/include/asm/pci.h
>   create mode 100644 arch/loongarch/pci/acpi.c
>   create mode 100644 arch/loongarch/pci/pci.c

Admittedly I'm also not familiar with the PCI code in general, but from 
what little my knowledge currently is, the changes look okay. (At least 
the code style and naming of things are reasonable.)

So, albeit a rather weak one:

Reviewed-by: WANG Xuerui <git@xen0n.name>