Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220514080402.2650181-1-chenhuacai@loongson.cn>
 <20220514080402.2650181-2-chenhuacai@loongson.cn> <64fdb3fc-87bb-53e8-52b5-36288de85cb3@gmail.com>
In-Reply-To: <64fdb3fc-87bb-53e8-52b5-36288de85cb3@gmail.com>
From:   Huacai Chen <chenhuacai@gmail.com>
Date:   Sun, 15 May 2022 21:14:52 +0800
Message-ID: <CAAhV-H7eFJriSHmU+BqTJXWaKa99-c-81t2nH1h-ceSH_4K6+w@mail.gmail.com>
Subject: Re: [PATCH V10 01/22] Documentation: LoongArch: Add basic documentations
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, Bagas,

On Sun, May 15, 2022 at 8:41 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 5/14/22 15:03, Huacai Chen wrote:
> > +1. Arithmetic Operation Instructions::
> > +
> > +    ADD.W SUB.W ADDI.W ADD.D SUB.D ADDI.D
> > +    SLT SLTU SLTI SLTUI
> > +    AND OR NOR XOR ANDN ORN ANDI ORI XORI
> > +    MUL.W MULH.W MULH.WU DIV.W DIV.WU MOD.W MOD.WU
> > +    MUL.D MULH.D MULH.DU DIV.D DIV.DU MOD.D MOD.DU
> > +    PCADDI PCADDU12I PCADDU18I
> > +    LU12I.W LU32I.D LU52I.D ADDU16I.D
> > +
> > +2. Bit-shift Instructions::
> > +
> > +    SLL.W SRL.W SRA.W ROTR.W SLLI.W SRLI.W SRAI.W ROTRI.W
> > +    SLL.D SRL.D SRA.D ROTR.D SLLI.D SRLI.D SRAI.D ROTRI.D
> > +
> > +3. Bit-manipulation Instructions::
> > +
> > +    EXT.W.B EXT.W.H CLO.W CLO.D SLZ.W CLZ.D CTO.W CTO.D CTZ.W CTZ.D
> > +    BYTEPICK.W BYTEPICK.D BSTRINS.W BSTRINS.D BSTRPICK.W BSTRPICK.D
> > +    REVB.2H REVB.4H REVB.2W REVB.D REVH.2W REVH.D BITREV.4B BITREV.8B BITREV.W BITREV.D
> > +    MASKEQZ MASKNEZ
> > +
> > +4. Branch Instructions::
> > +
> > +    BEQ BNE BLT BGE BLTU BGEU BEQZ BNEZ B BL JIRL
> > +
> > +5. Load/Store Instructions::
> > +
> > +    LD.B LD.BU LD.H LD.HU LD.W LD.WU LD.D ST.B ST.H ST.W ST.D
> > +    LDX.B LDX.BU LDX.H LDX.HU LDX.W LDX.WU LDX.D STX.B STX.H STX.W STX.D
> > +    LDPTR.W LDPTR.D STPTR.W STPTR.D
> > +    PRELD PRELDX
> > +
> > +6. Atomic Operation Instructions::
> > +
> > +    LL.W SC.W LL.D SC.D
> > +    AMSWAP.W AMSWAP.D AMADD.W AMADD.D AMAND.W AMAND.D AMOR.W AMOR.D AMXOR.W AMXOR.D
> > +    AMMAX.W AMMAX.D AMMIN.W AMMIN.D
> > +
> > +7. Barrier Instructions::
> > +
> > +    IBAR DBAR
> > +
> > +8. Special Instructions::
> > +
> > +    SYSCALL BREAK CPUCFG NOP IDLE ERTN DBCL RDTIMEL.W RDTIMEH.W RDTIME.D ASRTLE.D ASRTGT.D
> > +
> > +9. Privileged Instructions::
> > +
> > +    CSRRD CSRWR CSRXCHG
> > +    IOCSRRD.B IOCSRRD.H IOCSRRD.W IOCSRRD.D IOCSRWR.B IOCSRWR.H IOCSRWR.W IOCSRWR.D
> > +    CACOP TLBP(TLBSRCH) TLBRD TLBWR TLBFILL TLBCLR TLBFLUSH INVTLB LDDIR LDPTE
> > +
>
> I haven't addressed this in v9 [1], so I'm discussing it now.
>
> I think for grouping similar instructions lower-level list numbering can
> be used, like:
>
> 1. Arithmetic Operation Instructions
>    a. ADD.W...
>    b. SLT...
> ...
>
> Why is literal blocks used instead?
Because the instructions listed are not classified in a group. Thanks.

Huacai
>
> [1]: https://lore.kernel.org/linux-doc/Ym47ZAuwEA9as98h@debian.me/
> --
> An old man doll... just what I always wanted! - Clara