Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2690473iob; Mon, 16 May 2022 04:12:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmhwZ6aQGNMaftU/ANsE9QG76Sqya7hZfnjke4ITAmbwj+bLSJMmOjJdUBVNgaRoW4RVWs X-Received: by 2002:aa7:c2d4:0:b0:42a:a9a6:e73c with SMTP id m20-20020aa7c2d4000000b0042aa9a6e73cmr7677412edp.115.1652699566289; Mon, 16 May 2022 04:12:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652699566; cv=none; d=google.com; s=arc-20160816; b=sjC6LsLn5AraY1rVe3QccPRn4cXP76Xqdk7H2XKbK0ASKSbLl+TWEBCItLB4mpfs3V wdXpj919tMgxbzMQBCGa79mhDL+MmEDtwcUxtmGSxMIYwZxet175ii484hmwT2uqNQsI TZMkjhol8GdrgxnIcqGMOIqSndz+GVYCT32Ai+EhAd6HgDuyOX02elUu/iRTAc0ytASt ZMk9MLgRuinyOt84JZjP0hsKmiC7tdPsH4xSNVoJJ2DUPuwn62Dh2UBcftVJgc2uS2rl sZtrUaJsvDzsQ1KGzoqoGbLA1/9f3eZB1iATzO6gsWyUmvjt/rVoU27+4oepD8eNYgur FQnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=JH5uxlFrMRxg223R8wHlAv9FyX56Q3S3kFVZB4if3fc=; b=Z7vCDK6WqX3woXn2vgl9WsEgVgj1a+wpagQyN5lsBZWDg/EtxeWIDcN1hc6D4ilNba lp6cMg6oS2t1b557gde5628+vyFjS/77pJOcoo8RMP93pM/TYzKQ7e1A2Scct0TpOXV4 4fALSKkrNL1FSFvAnWGdM6NAQsNXe1zCO/t6Owxcl34OlRoVvmb+43Q2jdmpm3LbN3tT yxBiZ9hsdZcG+ok1PP3jQ+ygwOLKtnc96VhvyU4rDjw5HsYIKwwa7pxaeFwoxrM+UfUa 7qFLaz6xuQzK1vnyKcQzwprYQAgezwMzL8DMNYbSLRNfl9+SiMptL/yeYoQhcF9qBDvL Y18A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s18-20020a170906169200b006f3b74c80eesi10617754ejd.149.2022.05.16.04.12.19; Mon, 16 May 2022 04:12:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239093AbiEPFyg (ORCPT + 99 others); Mon, 16 May 2022 01:54:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232736AbiEPFyb (ORCPT ); Mon, 16 May 2022 01:54:31 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D31317E14 for ; Sun, 15 May 2022 22:54:29 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 678FB68B05; Mon, 16 May 2022 07:54:25 +0200 (CEST) Date: Mon, 16 May 2022 07:54:25 +0200 From: Christoph Hellwig To: Lu Baolu Cc: Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Paolo Bonzini , David Airlie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Daniel Vetter , Kevin Tian , Ashok Raj , Liu Yi L , Jacob Pan , Ning Sun , Will Deacon , Robin Murphy , Jason Gunthorpe , Christoph Hellwig , Steve Wahl , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] iommu/vt-d: Make intel-iommu.h private Message-ID: <20220516055425.GB12339@lst.de> References: <20220514014322.2927339-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220514014322.2927339-1-baolu.lu@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 14, 2022 at 09:43:15AM +0800, Lu Baolu wrote: > Hi folks, > > The include/linux/intel-iommu.h should be private to the Intel IOMMU > driver. Other drivers or components should interact with the IOMMU > drivers through the kAPIs provided by the iommu core. > > This series cleanups all includes of intel-iommu.h outside of the Intel > IOMMU driver and move this header from include/linux to > drivers/iommu/intel/. > > No functional changes intended. Please help to review and suggest. Thanks, this was long overdue! The series looks good to me: Reviewed-by: Christoph Hellwig