Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220514080402.2650181-1-chenhuacai@loongson.cn>
 <20220514080402.2650181-4-chenhuacai@loongson.cn> <25efb0c1-f2e7-0052-c925-08dd778d7ad7@xen0n.name>
 <CAAhV-H6rBtmTQTpxdZtk26sP9SJui5dpv2e-2ZUyWTtpxpf9FQ@mail.gmail.com> <689e103a-07f0-a55c-9b34-073cf81f84c0@xen0n.name>
In-Reply-To: <689e103a-07f0-a55c-9b34-073cf81f84c0@xen0n.name>
From:   Huacai Chen <chenhuacai@gmail.com>
Date:   Sun, 15 May 2022 19:47:13 +0800
Message-ID: <CAAhV-H7qWgRvmhREhyJF7cHKN6V+r1RFcZ1zit-VyevoQLFD9g@mail.gmail.com>
Subject: Re: [PATCH V3 03/22] LoongArch: Add elf-related definitions
To:     WANG Xuerui <kernel@xen0n.name>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Guo Ren <guoren@kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, Xuerui,

On Sun, May 15, 2022 at 12:13 PM WANG Xuerui <kernel@xen0n.name> wrote:
>
> On 5/14/22 22:11, Huacai Chen wrote:
>
> > Hi, Xuerui,
> >
> > On Sat, May 14, 2022 at 9:29 PM WANG Xuerui <kernel@xen0n.name> wrote:
> >> Hi,
> >>
> >> Why this patch is from V3? I guess it's by mistake so would you re-send
> >> a proper v10?
> > This is just a typo, it is really V10.
> Okay, got it.
> >
> > Huacai
> >> On 5/14/22 16:03, Huacai Chen wrote:
> >>> Add elf-related definitions for LoongArch, including: EM_LOONGARCH,
> >>> KEXEC_ARCH_LOONGARCH, AUDIT_ARCH_LOONGARCH32, AUDIT_ARCH_LOONGARCH64
> >>> and NT_LOONGARCH_*.
> >>>
> >>> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> >>> ---
> >>>    include/uapi/linux/audit.h  | 2 ++
> >>>    include/uapi/linux/elf-em.h | 1 +
> >>>    include/uapi/linux/elf.h    | 5 +++++
> >>>    include/uapi/linux/kexec.h  | 1 +
> >>>    scripts/sorttable.c         | 5 +++++
> >>>    5 files changed, 14 insertions(+)
>
> The code changes all look good to me, only minor typographic nit: please
> change "elf" to "ELF".
OK, thanks,

Huacai
>
> With that:
>
> Reviewed-by: WANG Xuerui <git@xen0n.name>
>