Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0eedc244-5c8a-c734-8bba-09a66d050a4e@quicinc.com>
Date:   Mon, 16 May 2022 14:55:50 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] serial: core: Do stop_rx in suspend path for console if
 console_suspend is disabled
Content-Language: en-CA
To:     <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
        <linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <quic_msavaliy@quicinc.com>, <dianders@chromium.org>
References: <1651484835-25189-1-git-send-email-quic_vnivarth@quicinc.com>
From:   Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
In-Reply-To: <1651484835-25189-1-git-send-email-quic_vnivarth@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

This patch will be dropped.

Uploaded this change as v4 of an earlier patch.
Apologies for trouble.

On 5/2/2022 3:17 PM, Vijaya Krishna Nivarthi wrote:
> For the case of console_suspend disabled, if back to back suspend/resume
> test is executed, at the end of test, sometimes console would appear to
> be frozen not responding to input. This would happen because, during
> resume, rx transactions can come in before system is ready, malfunction
> of rx happens in turn resulting in console appearing to be stuck.
>
> Do a stop_rx in suspend sequence to prevent this.
>
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
> ---
>   drivers/tty/serial/serial_core.c | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 82a1770..e8c6875 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -2211,9 +2211,16 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport)
>   	}
>   	put_device(tty_dev);
>   
> -	/* Nothing to do if the console is not suspending */
> -	if (!console_suspend_enabled && uart_console(uport))
> +	/*
> +	 * Nothing to do if the console is not suspending
> +	 * except stop_rx to prevent any asynchronous data
> +	 * over RX line. Re start_rx, when required, is
> +	 * done by set_termios in resume sequence
> +	 */
> +	if (!console_suspend_enabled && uart_console(uport)) {
> +		uport->ops->stop_rx(uport);
>   		goto unlock;
> +	}
>   
>   	uport->suspended = 1;
>