Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2704619iob; Mon, 16 May 2022 04:33:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwReOjT0QI7e/8o+1/3UWLFo1Vvkafx844RigkiHPvjurooS4E8Uk/Pfb2ifh2prrfoaSx8 X-Received: by 2002:a17:907:94c5:b0:6f4:6de1:399c with SMTP id dn5-20020a17090794c500b006f46de1399cmr15161020ejc.336.1652700783575; Mon, 16 May 2022 04:33:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652700783; cv=none; d=google.com; s=arc-20160816; b=FPq00y47VdI0Nh0+U34Ox44jazsRUqNfNZeQNrK3k3xbXugr4L2bQSKFGQ/cJja7bD WYfDH90w1OMZ2FA9zB+J68zltWeYKWVBTm+RQIpxtg+5Is+5HZ0xHZOIipZ6joLxTuV4 iv9BEgKFaF4Es/5MMCuGqrn0SFOue+KsULh660fzqk/aQRnar/26YiCMoNSUJbfJzm0+ w3SBURAk5BQ3nKG1FKvL7tCIhjozMZviBmyi2RyVsfsurIhgdaoNvLNEzuCvpqN9p1si 1Zlgf8LaV8pVnlHkI5BNDTmPOrd9wrWJX5TKbvMv5s0vrzWnh9qRkcn0aeGC2WWVMBRC CXLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=KQnul6BomttjXRAElW8MXsYWinaGJAdMxQ34JNltdPE=; b=Cc4asEXeLmKx9OkApPHysEooAqtYdDbDZhJsfgmtfQhq3kV4kgN6cyCvDHinM2qicP la01a62KRicfRD5XQZ4J1Bh6R99ZTQ5wdIRehNGhwQHV1e0Gt4Zu4aYJF3BjG7Tops3w 6FPaXpybvssQamomdM+TabXtoYVkhBUHq1Ti8vb0KiH8sP7YMp5I8c9PeWAZ5IcQ7j6p l0F0dDAT3R76L6zJovzzB4TinLbFKaijdM+H2m55WYyJU8PC8VTERykOJNnyDhkHTnZf LsK5h8oPEOSYDZ+bEjrzrgaUv4Ln3SG1vIe60fb5ZYKG/iAYu0l1uGtjfIq1IkxuDYBt /52w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=lHEnF6he; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b16-20020a056402279000b00427ba20da27si11416996ede.78.2022.05.16.04.32.35; Mon, 16 May 2022 04:33:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=lHEnF6he; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236835AbiEPB4V (ORCPT + 99 others); Sun, 15 May 2022 21:56:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236803AbiEPBz4 (ORCPT ); Sun, 15 May 2022 21:55:56 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5919462C7 for ; Sun, 15 May 2022 18:55:54 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id gj17-20020a17090b109100b001d8b390f77bso16013694pjb.1 for ; Sun, 15 May 2022 18:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=KQnul6BomttjXRAElW8MXsYWinaGJAdMxQ34JNltdPE=; b=lHEnF6heGEjJ30vDGmBAz//0dsf9/RNBPwzN+OFFUpaPvjAovS+THylUPUacjSp6df 12B4Wy+uYihi9szlnkEPWXJDvL5sd4FqIbsJ5+5K6L0zjbr5QUN7eFoVdz0Uqo2BxA9C AqzLXKBpDNfAG1hXLUxIajsWYpek5ukHHrY1iwVscUHinDQK+XVisRXfGex8dOOya/Vq rbNIwnbyZGCrS/iYhZWWm2k2qdzp22US3fvOjFOpxyFkL3psSHsu0SbMMbWyF+/OmN6q A9ili3tCLYcJoQZ0wb1WqHEar+/5/bGXsjDXO9jmpd5ncQ5rs3Ca6oxtEI3vq/ZD1X3i 2z8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=KQnul6BomttjXRAElW8MXsYWinaGJAdMxQ34JNltdPE=; b=aij2v8fbqziCjmiZQ89BvJ6YRDniKe/ibRu99Us4Up9eSrzwL+mPCRDVBrmpnkFGlf WvhWkQgYo4BYXgBOfkL//mYGJjk9rVbiZ3kQUgIfZFA6kzEfsY4I9pUbtvskq8IfK3lS KM8sHAgbKd4SsO7yvhqSv+CypGmW4lPXGEvzz+LfuxQK9hEMUAbpqgPLHnf+Iw97KkGD YmUeMdN+vgDyEcTmy59LasfI1T6EnIs5h505soY9PONXh1kTe8T2ayfc4pcH4fw48lOa AgeUpJ92f5gw4xBZ8TDJEPE6VFy5Dvx3KeLXOMi38Nr3p1YB9fUlef34e346o0WUuuWQ 905w== X-Gm-Message-State: AOAM531mgp5SHX22lrYcFt4PqNnFqfZMfAD0NmSsZXr3aQE1ESuBVZyG tDWq6pLHlmWDvTg+mJjSDZAcYA== X-Received: by 2002:a17:90b:1251:b0:1d7:f7ae:9f1 with SMTP id gx17-20020a17090b125100b001d7f7ae09f1mr28343920pjb.65.1652666153928; Sun, 15 May 2022 18:55:53 -0700 (PDT) Received: from [10.71.57.194] ([139.177.225.225]) by smtp.gmail.com with ESMTPSA id y6-20020a655a06000000b003f24a2be89asm3137216pgs.8.2022.05.15.18.55.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 May 2022 18:55:53 -0700 (PDT) Message-ID: <192be0a3-47dd-221d-0061-4e04e489ff89@bytedance.com> Date: Mon, 16 May 2022 09:55:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [External] Re: [PATCH bpf-next v3 0/2] Introduce access remote cpu elem support in BPF percpu map To: Daniel Borkmann , ast@kernel.org, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, rostedt@goodmis.org, mingo@redhat.com, jolsa@kernel.org, davemarchevsky@fb.com, joannekoong@fb.com, geliang.tang@suse.com Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, songmuchun@bytedance.com, wangdongdong.6@bytedance.com, cong.wang@bytedance.com, zhouchengming@bytedance.com, yosryahmed@google.com References: <20220513063952.41794-1-zhoufeng.zf@bytedance.com> From: Feng Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/5/13 下午11:01, Daniel Borkmann 写道: > On 5/13/22 8:39 AM, Feng zhou wrote: > [...] >> Changelog: >> ---------- >> v2->v3: Addressed comments from Andrii Nakryiko. >> - use /* */ instead of // >> - use libbpf_num_possible_cpus() instead of >> sysconf(_SC_NPROCESSORS_ONLN) >> - use 8 bytes for value size >> - fix memory leak >> - use ASSERT_EQ instead of ASSERT_OK >> - add bpf_loop to fetch values on each possible CPU >> some details in here: >> https://lore.kernel.org/lkml/20220511093854.411-1-zhoufeng.zf@bytedance.com/T/ >> > > The v2 of your series is already in bpf-next tree, please just send a > relative diff for > the selftest patch. > > https://lore.kernel.org/lkml/165231901346.29050.11394051230756915389.git-patchwork-notify@kernel.org/ > > > Thanks, > Daniel Ok, will do. Thanks.