Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] gpio: ftgpio: Remove unneeded ERROR check before clk_disable_unprepare
Date:   Mon, 16 May 2022 16:50:00 +0800
Message-Id: <20220516085000.9861-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vpuScBugjw2eZxJzLJM0lnm0+6kDxn0gIFmDflo85EvGW3pFDXXBToHfXFJB?=
 =?us-ascii?Q?yGEHnShXqXCUMg5o7wbTCbrsmxfzSY4iHhoLIPEg208yCce2Ow4S/YC4VVD8?=
 =?us-ascii?Q?Ezyz42n4FQQDlU9sRTgraD6wrcbBlR6vxdIePiQL71mn//1zubF3mhAUHZ32?=
 =?us-ascii?Q?S6SyvIWTSno2L1d+j3nZ0Xil2s5jV0MUpu/QI8c7kq1eqkX9rs5xJ91NtrAb?=
 =?us-ascii?Q?bgmkVxjsIBj5OaDtZhnpbrPD/w1bU0ogudL1T+AOxv/N2f/Vf1xbF5y2DjkV?=
 =?us-ascii?Q?BBOdyXlEBbnvqfsyiZKrijyfroB5bqwMQ0/fqqmnibm6BbHUf/i9Zsp7FxJC?=
 =?us-ascii?Q?4bzDQ1/HgVlFLOeytSql1t4waodxkpnK+oSwN1w0cQth84uw4okfhiqaUkTu?=
 =?us-ascii?Q?G1WxTiislww1f0SmEykuk0PerSOWZrPj2k+hLOvvZBSypI04NCZ3XHQgEz9c?=
 =?us-ascii?Q?ZLPyBrnCrstxExzBa4lHVqitMopE8o0EfxIUA5waZRWcgoUHmIF/R4jxfrmB?=
 =?us-ascii?Q?21T2RsA7NLRNg7ZRfpLwi8PV0cf/fcOBwuNU5H+EdZScS3OZ9Ah1MnjlqC7y?=
 =?us-ascii?Q?46YwfX+yZ7DrdxOgnFtzV35JW6fsP+LPOTD7pCnTCWov06U6417KrCzODSg5?=
 =?us-ascii?Q?0hzpR5A3+Rof3B95CCXkCsfDM8lwQo/r1aSmz9/gSZGdMyqbcpVDuQnL4jtI?=
 =?us-ascii?Q?EIer8ie61V+Zoqy83NhBI/UUjoPwahWKVWDfJ8c5S6ktaNF7UxO6/CPc/yTx?=
 =?us-ascii?Q?9vKreJmUKm9j11cy4djGU/F4OX4rx7Dt0hfB9lCeDLc15inRJ+98rgK2sdFu?=
 =?us-ascii?Q?OsFmR/DQF/ODqpVdzqv8KuwbOrY178LL7jzQuJbdWSYWAtdvcxBcZ+ZUNuQs?=
 =?us-ascii?Q?EyVDePKrn3eJUDT11XObLw2Fs8U39EjDT8VPOhCWTuJK1pRtmxGRiOnbHoYa?=
 =?us-ascii?Q?cNmUhVbWtLNpODYMm+63hiiMJVtpxucSnBkuSrCseFPAgZKM3Eba03FzpfBO?=
 =?us-ascii?Q?JDIbz54DCImyCLnjqWYMQ53PsOUuT1X9dyK+h20kvQv1YMpkq8Ep1TyxfR1Y?=
 =?us-ascii?Q?bQH+KUxcybpdVPMlu4EJblYiWbvSicMygsdxgTOZGbM8OyT9Jd0/90Va8haE?=
 =?us-ascii?Q?vrCdCZi7DdmS1IynIEZgEDS93Ovukfe/QrI2hCwJOX/IMQRkiHfaHFrHLO5I?=
 =?us-ascii?Q?gw1Bj7fN5NSUuIo2yhw7CtgHEiYnSzyIWE5aPpCvUKWWjLVuTfKXZ24/xdzW?=
 =?us-ascii?Q?Tkhi29YxdE2iAZxyg8726p92h8r74rqHEAXo9NFvTYOHytmQvDJ+SJ5GPcMM?=
 =?us-ascii?Q?SLb4np9ISjKKotVw995qeDdVVm86eNdVNN2Us0Mnw1SipftU8K1Cm4AFXmGa?=
 =?us-ascii?Q?sjbh+w+cQ9lHFCF2dnI0rAuQ6Yx0Lfnyns1/UHdStgQRJ5fpXbV5PFdpnspg?=
 =?us-ascii?Q?LrkWeHOCHHiUDOJ602XH37R6oik9fn9RfOBzy34D2EQMhHSzmL0iOK4ayxjh?=
 =?us-ascii?Q?Vyef2zkU+xnNbtu3xULvjGxUsf0cSLPi2T9yfdIIVf7E4dKqGS8Pqz/Wnqn0?=
 =?us-ascii?Q?LHUEn7TC0YIydjdIKAT1o0CMNN88ptF5eOLr7HUeolVSg2IUO76pBwt+H6Fo?=
 =?us-ascii?Q?JrqjR76gxXcg+Sdobm9Qy9BdcRG8aKULfstmMEjWEVUiU1dC6WQ0ACglRJIM?=
 =?us-ascii?Q?YWlcgmwC4II7xyiRSzBTsCgG5CnhiWNUwux9AULrNMBy05dhv6XlKHxPchte?=
 =?us-ascii?Q?7/0L36gnkg=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1e2f99d-8bde-410b-f707-08da3719149d
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 08:50:08.8296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fQ4YWBGG7S14MkOPrEUaQFSYHtF6+OG9R8fdXh11dHbgwjGvNukLpd1vM8QeHR/ZXHSfog86rANnRZXqb6E7bA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2433
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

clk_disable_unprepare() already checks ERROR by using IS_ERR_OR_NULL.
Remove unneeded ERROR check for g->clk.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/gpio/gpio-ftgpio010.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
index b90a45c939a4..f422c3e129a0 100644
--- a/drivers/gpio/gpio-ftgpio010.c
+++ b/drivers/gpio/gpio-ftgpio010.c
@@ -315,8 +315,8 @@ static int ftgpio_gpio_probe(struct platform_device *pdev)
 	return 0;
 
 dis_clk:
-	if (!IS_ERR(g->clk))
-		clk_disable_unprepare(g->clk);
+	clk_disable_unprepare(g->clk);
+
 	return ret;
 }
 
@@ -324,8 +324,8 @@ static int ftgpio_gpio_remove(struct platform_device *pdev)
 {
 	struct ftgpio_gpio *g = platform_get_drvdata(pdev);
 
-	if (!IS_ERR(g->clk))
-		clk_disable_unprepare(g->clk);
+	clk_disable_unprepare(g->clk);
+
 	return 0;
 }
 
-- 
2.36.1