Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4aeee9a4-e8e1-bcac-1ebb-f2b8860ba363@infradead.org>
Date:   Sun, 15 May 2022 22:19:16 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] scripts:modify output format
Content-Language: en-US
To:     Dong Chuanjian <chuanjian@nfschina.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Changbin Du <changbin.du@intel.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Cc:     linux-kernel@vger.kernel.org, Kernel@nfschina.com
References: <20220516020442.GA4277@localhost.localdomain>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220516020442.GA4277@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

The change looks good to me, but there are a few other
"process" problems.

1. Was there a compiler warning that caused this patch?
If so, then tell us about it.

2. This is v2 of the patch. You should describe what changed
between v1 and v2 (below the first --- line).

Thanks.

On 5/15/22 19:04, Dong Chuanjian wrote:
> scripts:modify output format
> 
> Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>
> ---
>  scripts/kallsyms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 8caabddf817c..ba50993785ec 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -498,7 +498,7 @@ static void write_src(void)
>  
>  	output_label("kallsyms_token_index");
>  	for (i = 0; i < 256; i++)
> -		printf("\t.short\t%d\n", best_idx[i]);
> +		printf("\t.short\t%u\n", best_idx[i]);
>  	printf("\n");
>  }
>  

-- 
~Randy