Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2867018iob; Mon, 16 May 2022 07:55:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyouaj+SFlCeupdV9ZpWF+h2ScujN152/HcQhsdXcTrDIDprwi3Q6gUa2qlOMBTgR/bQLDW X-Received: by 2002:a17:907:7745:b0:6f3:674a:339 with SMTP id kx5-20020a170907774500b006f3674a0339mr15407728ejc.207.1652712931405; Mon, 16 May 2022 07:55:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652712931; cv=none; d=google.com; s=arc-20160816; b=NKsPEkTxA2cKfos4K71IvxDlR8O6k/4WixXo5MAQ/tCgGPuvgNbc0vydQhdlNNTeeH 4KyTHxaug+LyRZ1mmu4FHb6BI69ox00jIAFyK+MjkAndw91xCtyV115Pho+wPPJJf8ew TGNXXaLFv4H+tQePYU3wNvuX+vE25H9Nzz3WGghWcYfDOvmMlEuxfaYs+Vi5t/zwCMRS soJJspEQtdNTsA3HgOVUHMfr0vIu+nDicul/oWegRFY9cSjDzaZAJ7Kl1tMJot0NItMw AmInp0I8PQ+3C7eKzEVOl+163RyaOoeCLZ9enuJcH7mBfOAj5YtArKulO8FMOZw4hxZC Uj8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=shicjTKBtrtuDcaN2NsbxhwfQnbe4P6u6jZjTty+jvI=; b=TyLeYq3Kkk2Y0+SqjI+pi1Zq8KS0WA78XfewA9pr/QOr50Xnz9PLcGTpwArWQuQTKG Hx8f59Z5YR2w12/4PSNwyM0cXfj+f5/KtE96rk4pzbdHBRBD602uLp6xbVZ1aLC2ahLf 0ahr/jOQ0WfrTqbDiqg5BhJ0/pjGit8poG6BegumQ8KtK02jDDXCfoEY7BVqZgguYTtQ PcbodIll149LKMc18vxJojI+/WOBhd+fx7AqXUgDxIXglk2cNELl0h8weW/0gs9bVczn ZXtKdf/l+e+BMd4oU+lN8U8KGLQdrKM8V4uOwXr5YT8VMcJaOsORZJfrjsU0pFtpEe6e nKfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P4NpdP8g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x23-20020aa7dad7000000b00425b7a7e3ccsi8729005eds.225.2022.05.16.07.55.05; Mon, 16 May 2022 07:55:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P4NpdP8g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236152AbiEOJu4 (ORCPT + 99 others); Sun, 15 May 2022 05:50:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235210AbiEOJuy (ORCPT ); Sun, 15 May 2022 05:50:54 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EB0E2EA15 for ; Sun, 15 May 2022 02:50:51 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id t25so21271310lfg.7 for ; Sun, 15 May 2022 02:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=shicjTKBtrtuDcaN2NsbxhwfQnbe4P6u6jZjTty+jvI=; b=P4NpdP8gMX4y3C6YTYYB9Nre+Yy7M1p6asm/4EkODj179NE84yTYgfBRBKmG8Z7SA0 +ua4WeNEU0y+fUYbcz1fsVq6rVZkM9D+ElBVUTpacF2Rgfh2f5pXnwHtUQSlb3EVGCKh 7UthSL65O/YTpmLBRbVWkLaIb118nbb/DK9CESGDMIL1Kc5H3hUtl/54+KL6dHmx2oiI ZZhDJRQDk3A0HxN1FemJc8XmsRjhBSLMWWuV4zvea5C4vtaNOrfwhG5mPykKNCW2y44x OcEOqIUkJHeWiDivadQf0ROtZnh6CsTtQ105UIGXWmQyk37RZiIIyzpjYrgEODD/9Ox2 uMiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=shicjTKBtrtuDcaN2NsbxhwfQnbe4P6u6jZjTty+jvI=; b=hDt70zDXAe3ZT7PIrS0xBfgwo77wA+N1Xu40ReYfqHgM+Dc28aG1vuTR2CA+5NrF9T TYTqxkbqSF0DxGR/OYuATa0/dI8Ngf6BYPIdBB4+dmgsGcpj1uxMn2jMGmLu+GsaBXEp jso/caiKFPwNBJBFi/YMICtoeEkXLq8dTGdTBT51t0bUP6cUlBTWSVQPOminZPIzP576 oEnU9RS+s9d4aLNOe2vwfvaMOSij5JsX5WSbqEJIHo59WjKqv5tnRN/iiq5ioqkRnemC Vy7NwBi4qc21vS/7iU4CyKkZKFlb2jRy2a3pdls7fZ8ZWRYxTylYzSfhqXkccdwqRu7b v++Q== X-Gm-Message-State: AOAM533YFo4T8BndRqwiwPLicJi1guen0Ijc38faEx+kiZ7ednKtt+xg Jwj9qqhrN7ZoyG87NQ34mFEoHg== X-Received: by 2002:a05:6512:3993:b0:473:1953:59 with SMTP id j19-20020a056512399300b0047319530059mr9067511lfu.269.1652608249643; Sun, 15 May 2022 02:50:49 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id d21-20020a2e96d5000000b0024f3d1daec7sm1129326ljj.79.2022.05.15.02.50.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 May 2022 02:50:49 -0700 (PDT) Message-ID: Date: Sun, 15 May 2022 11:50:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCHv2 2/6] thermal: exynos: Reorder the gpu clock initialization for exynos5420 SoC Content-Language: en-US To: Anand Moon , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220515064126.1424-1-linux.amoon@gmail.com> <20220515064126.1424-3-linux.amoon@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220515064126.1424-3-linux.amoon@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/05/2022 08:41, Anand Moon wrote: > Reorder the tmu_gpu clock initialization for exynos5422 SoC. Some more thoughts: where is the GPU here? This is a TMU driver... In subject you also describe GPU. My comments about unusual code order from [1] were not answered. https://lore.kernel.org/lkml/CANAwSgS=08fVsqn95WHzSF71WTTyD2-=K2C6-BEz0tY0t6A1-g@mail.gmail.com/T/#m3edd1fa357eb3e921e51eb09e2e32d68496332eb Please respond/address to all comments before resending. Best regards, Krzysztof