Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d32c3898-523a-8b64-fa95-4f59a5f2fca6@amd.com>
Date:   Mon, 16 May 2022 19:16:59 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2 6/8] perf header: Parse non-cpu pmu capabilities
Content-Language: en-US
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     peterz@infradead.org, rrichter@amd.com, mingo@redhat.com,
        mark.rutland@arm.com, jolsa@kernel.org, namhyung@kernel.org,
        tglx@linutronix.de, bp@alien8.de, irogers@google.com,
        yao.jin@linux.intel.com, james.clark@arm.com, leo.yan@linaro.org,
        kan.liang@linux.intel.com, ak@linux.intel.com, eranian@google.com,
        like.xu.linux@gmail.com, x86@kernel.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220509044914.1473-1-ravi.bangoria@amd.com>
 <20220509044914.1473-7-ravi.bangoria@amd.com> <YoJRYI2P0EEnhZXv@kernel.org>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <YoJRYI2P0EEnhZXv@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEFjZExPcXVxb3VRblBhbXUrY0pSMmpvZWE2cG5vQTFoVkZnQWZyVitZaWZM?=
 =?utf-8?B?RHAzUk5JK3ZqTnQvWVUyNWRUV1lzcDE5YmRZK2JiSUVxcFAzbFI5R0l4MTdq?=
 =?utf-8?B?R2YwaHdMWFZERi9LZTFSL0xubDMyUk1FNkoxaU5IcDdrOWNSMVY0N2F3TFpl?=
 =?utf-8?B?UURmOEVOeVBaNkV0QkZLWklJdC9tNTFTWGs4dW9vZVVzVlNvVXUyRlV2Q09J?=
 =?utf-8?B?NE92N25VczE4cXFpUGh3dVNhS1FXRmFxWW9kU1ZYQTkwYzlNVXNwUi8zWWNM?=
 =?utf-8?B?UHVtcWxjVDkwN2lJM0FTSGtrdHNiUnhabkJzajRKWE1IV0xaekNxRjgwc0N6?=
 =?utf-8?B?U2k5Wm9Za21GNmNSSVlsU0FCRWRyYlVpaTQrQjltaSt6VFhTL3dlTFNwUUpP?=
 =?utf-8?B?Z3ZaM0FrUVFOQmFPM2tmQU52ZzcvajV3WlZNY3JIYmhZcStkTXdBWUs3NEF1?=
 =?utf-8?B?d1Yrc3QzQThNcWkwcWVKaXZZdHp1anpVRjBMNUV0aTR1SUt4Ync4elcxcnVs?=
 =?utf-8?B?RnJBZncvc1VJQ3hWU3FHS000SFFDTnl3R2dBc2kzTG4zVGRpVWNhaWFYWERL?=
 =?utf-8?B?ZFl2YlpXY1lCSWYwMG5LcEpuejRiR1l0RGxjTXRiSmtXd0ZmZklybWIvQVho?=
 =?utf-8?B?T1hPZFhYS3Zsc00wcnZFeGFMc0Y4V0NYSktIZTlndm9wc3pUdzVMZUxZLzNl?=
 =?utf-8?B?MHFXSU9LYko3cXByMHNCMnh2Y3RNYzg4OTEzb0JDZWNkWnRlN3M3eUIyUUpQ?=
 =?utf-8?B?Wi84TTUxWXRHanVSa3pxc09QL1laOXNWZThwOGVtYlJtVHByWHJXR2hDaGFo?=
 =?utf-8?B?L251M3RMOGE1cXNpRkthTFdiWCs4eWU5UFlKOEdXR1JjYVVlVFJkak9RZUxW?=
 =?utf-8?B?b0lLT0FZSmVHaHFINDUvRmU1UjhNVXUzbENkZEJnMUlKMWdMK04yQ0Q0RElU?=
 =?utf-8?B?MnRkMm9tOWg0T2F1dHlQSkRzQk9SUXM1K1AydXo3TTdMei9ETUF6S3VnUjlT?=
 =?utf-8?B?bnFGTU5rNFBEc3paVm1xaTF2L3QzeVFaMWZDR3FIUEM5NC9Ga1YrSXY2c0RE?=
 =?utf-8?B?Yk5pWm5PUUxqVWVtdmlCTUpHU2VkQ3AzTDBrNVF0ZElHamJtclFsbFM2UUdm?=
 =?utf-8?B?T3JmcjFiQXg0UCtQTW81OTdhL0JWN3IwVDh5bHJ4NThGK21CcjkwSHp3K0VM?=
 =?utf-8?B?dVQ5bGRRN2RqdDBzSkd5c3lndU9nRGY3bGJnWml5ZG1WZU9UYmtmNTk4dXo0?=
 =?utf-8?B?MWpaQ0FGU21YQ0Y0Q1pYRENRRHVlQVhEUVR4T0ErZGFIOTBVd0pkbE1Jcjdh?=
 =?utf-8?B?VlplWmNQSlE4cDFwOUU2Qk8yc1lPYlF1bTVnU0JUdlRsNk4vV0o1SE1qaENs?=
 =?utf-8?B?VnBqdUZKWlQ2R3owaVJQMlVyUkVleG85VDEzd2QrMWNoQ0RycGtsbEQ0ZWE5?=
 =?utf-8?B?TWpLWVVhU0pjQTg5Nm5RbGVNbXhwMnhTT2NkWmNMdC9USjRGQ1FvS1dyT0cx?=
 =?utf-8?B?VzZTTXJjV1crLytyYkdJZTZmUktYVHFBSFZVekQ2RS9MUEY2OTZHSmdIRGl1?=
 =?utf-8?B?M2Q0M0lZaGRJSVRhN0JURUZpemNjTERrcUV6c0pOMzRMQUdxRXh0SGZuaHJa?=
 =?utf-8?B?dm5oUmYveS9PZ09jMjg0S29uNmlFeVJKeXo4UVBvU3VmVWp5UTJONTRjNGRr?=
 =?utf-8?B?ZEhqNDJjQnNNbWRQLzN1VjhzWFZpYTJoT25nanFPaHdQUzQ0elU3QlNteXZh?=
 =?utf-8?B?UzlBbVNGNkUxOHNlNnpKalM1QUExcXpkM1pkTWRRdDJYZHgxcWZ1bGM5LzFV?=
 =?utf-8?B?RVBpZmt3S2tlYWZJODFuNGt6cGdCQ2x0eEJhemQrbzB0dEI4L01rOWtkMWZo?=
 =?utf-8?B?Y2pYY0NJMkt0aWY4VFZZa1J0QmhPL21ZY3ZpcFdKUmRLajBSLzVXUFFCNExa?=
 =?utf-8?B?UnpMMlpMcXdhMmFiK2ZPMUdJYVBjWnV0U2dQeDZ4MHdqWlNyTHZzQmVuV2Nr?=
 =?utf-8?B?MzhOYWROeXpQa0FETG05UDMvL0IrczFlbE5TdUNNQ1BHVGk2KzNqREV6VkNR?=
 =?utf-8?B?WE80TmFrNDA0KzBkZWRrdGVvbWN1TmIrWStwZkgvaXUxVE0xMmJxd2lOUnZz?=
 =?utf-8?B?RGNjUFZUVXM4Y2VLb1ByZXh5bTBab25hdkRkNng0d2RDNW8ybllHNVlCL1ln?=
 =?utf-8?B?OFBCZzJjVks0Qklma2ozQ3VRRW5GbG5IQnhRUk5RZG1jeTNTVnlFbmIvWkxU?=
 =?utf-8?B?K1I4Z0FDakl2VHdxdncyQnhTSXYvdlBxTXpqRjBjOFgxTkREam9ZQnBoTXFD?=
 =?utf-8?B?djU1UkJjazlhTmUwWk5pR0FwZVNORm5uUk1hWk1lM09xRXpGdGRqQT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e19a064-8d51-41f8-3f7f-08da3742983c
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 13:47:19.1549
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +9+Vb9wF8YcArFDyBhKyaqF9cmkLHJIgXcJcBOgRyTgtDfYECTYtLeO199bllJu40y8ChwZVm+mS8/kYLwoQxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6657
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 16-May-22 6:58 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, May 09, 2022 at 10:19:12AM +0530, Ravi Bangoria escreveu:
>> Pmus advertise their capabilities via sysfs attribute files but
>> perf tool currently parses only core(cpu) pmu capabilities. Add
>> support for parsing non-cpu pmu capabilities.
>>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>> ---
>>  .../Documentation/perf.data-file-format.txt   |  18 ++
>>  tools/perf/util/env.c                         |  48 +++-
>>  tools/perf/util/env.h                         |  11 +
>>  tools/perf/util/header.c                      | 211 ++++++++++++++++++
>>  tools/perf/util/header.h                      |   1 +
>>  tools/perf/util/pmu.c                         |  15 +-
>>  tools/perf/util/pmu.h                         |   2 +
>>  7 files changed, 301 insertions(+), 5 deletions(-)
>>
>> diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
>> index f56d0e0fbff6..dea3acb36558 100644
>> --- a/tools/perf/Documentation/perf.data-file-format.txt
>> +++ b/tools/perf/Documentation/perf.data-file-format.txt
>> @@ -435,6 +435,24 @@ struct {
>>  	} [nr_pmu];
>>  };
>>  
>> +	HEADER_PMU_CAPS = 32,
>> +
>> +	List of pmu capabilities (except cpu pmu which is already
>> +	covered by HEADER_CPU_PMU_CAPS)
>> +
>> +struct {
>> +	u32 nr_pmus;
>> +	struct {
>> +		u8 core_type;	/* For hybrid topology */
> 
> Humm, I'd say use u32 here and..
> 
>> +		char pmu_name[];
>> +		u16 nr_caps;
> 
> Here, no need to save space here, I guess.

Yeah I know it's not a biggie but fwiw I thoughtfully allocated space.
256 types should be more than enough for core_type. Similarly no real
pmu will have more than 65,536 capabilities :)

Anyway, will convert them to u32.

Thanks,
Ravi